Repository navigation
fix(tailwind): explain why box-shadow utilities are skipped - #3631
Open
maiconhenriquefa wants to merge 4 commits into
Open
maiconhenriquefa wants to merge 4 commits into
maiconhenriquefa wants to merge 4 commits into
Conversation
|
@maiconhenriquefa is attempting to deploy a commit to the diegomura Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: f8bca6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3558
shadow-*andring-*are valid Tailwind classes, but react-pdf can't draw box shadows, sotw()skips them. Today that shows up asInvalid class "shadow-lg", which reads like a typo or a bug.The behavior stays the same (the class is skipped and the warning shows once per class), only the message changes for box-shadow utilities:
It covers
shadow-*,inset-shadow-*,ring-*andinset-ring-*. I also added them to the unsupported list in the README, plus a test and a changeset.