[开发中]Swiper 支持bindtransition 和 bindanimationfinish#2391
Open
xiao19880917lu wants to merge 1 commit intomasterfrom
Open
[开发中]Swiper 支持bindtransition 和 bindanimationfinish#2391xiao19880917lu wants to merge 1 commit intomasterfrom
xiao19880917lu wants to merge 1 commit intomasterfrom
Conversation
xiao19880917lu
changed the title
hiyuki
reviewed
Mar 6, 2026
| }, () => { | ||
| currentIndex.value = nextIndex | ||
| runOnJS(runOnJSCallback)('loop') | ||
| runOnJS(runOnJSCallback)('handleAnimationfinish', nextIndex) |
Collaborator
There was a problem hiding this comment.
以及建议将这两个runOnJS合为一个，在js函数里再去分发，而不是调用两次runOnJS
hiyuki
reviewed
Mar 6, 2026
| }, () => { | ||
| currentIndex.value = nextIndex | ||
| runOnJS(runOnJSCallback)('loop') | ||
| runOnJS(runOnJSCallback)('handleAnimationfinish', nextIndex) |
Collaborator
There was a problem hiding this comment.
以及建议将这两个runOnJS合为一个，在js函数里再去分发，而不是调用两次runOnJS
| timerId.current && clearTimeout(timerId.current) | ||
| } | ||
| // resumeLoop在worklet中调用 | ||
| function resumeLoop () { |
Collaborator
There was a problem hiding this comment.
用'worklet' flag声明清楚哪些函数是worklet哪些不是，不要都依赖隐身判定
| currentIndex.value = selectedIndex | ||
| offset.value = resetOffset | ||
| runOnJS(runOnJSCallback)('resumeLoop') | ||
| bindanimationfinish && runOnJS(runOnJSCallback)('handleAnimationfinish', selectedIndex) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.