Repository navigation
fix: do not apply metadata item style to pivot table dimension labels (DHIS2-22215) - #3479
Merged
Merged
Conversation
Upgrade @dhis2/analytics, where the pivot table reads the label style from `dimensionItemStyle` instead of `style`. This prevents style coming from the api (e.g. data element color set in maintenance) from being applied to the dimension labels. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Contributor
|
🚀 Deployed on https://pr-3479.data-visualizer.netlify.dhis2.org |
janhenrikoverland
changed the title
dhis2-bot
added a commit
that referenced
this pull request
Oct 4, 2026
## [101.6.4](v101.6.3...v101.6.4) (2026-10-04) ### Bug Fixes * do not apply metadata item style to pivot table dimension labels ([#3479](#3479)) ([eb8f923](eb8f923))
Contributor
|
🎉 This PR is included in version 101.6.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pivot table dimension labels picked up the
styleobject frommetaData.items. That object comes from the api, e.g. a data element color set in maintenance, and was applied as CSS on the label.@dhis2/analytics29.8.1 (dhis2/analytics#1845) reads the label style fromdimensionItemStyleinstead, which is only set by analytics itself (the "No value" item in the event response transformer). Aggregate pivot tables in DV no longer get styling from metadata items.Before
After