#2103: Integrate Obsidian - #2380
Open
Paras14 wants to merge 8 commits into
Open
Conversation
…/2103-obsidian-commandlet
Collaborator
Coverage Report for CI Build 33179972847Coverage increased (+0.02%) to 73.631%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions8 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #2103
Implemented changes:
Obsidiancommandlet extendingGlobalToolCommandlet, based on the URL Updater from Create ObsidianUrlUpdater #2186 (#2186: create obsidian url updater #2203).exeis executed and not extracted.dmgis extracted so the*.appcan be taken out of it.tar.gzis extractedCommandletManagerImpldocumentation/LICENSE.adocObsidianTestcovering registration, tags and the per-OSisExtract()branchesTesting instructions
mvn clean test.ObsidianTestandHelpCommandletTestshould pass.ide help obsidianandide --locale=de help obsidian. The English and German help texts should be shown.ide install obsidianon your platform and check that Obsidian is installed.Note on step 3:
ide-urlscurrently contains no metadata for obsidian, so version resolutionfails and the installation cannot be tested yet. The metadata is only created once the URL
Updater from #2186 has run.
Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»In Progressand assigned to youpom.xmlfiles or otherwise if runtime dependencies changed, you have updated LICENSE.asciidocChecklist for tool commandlets
obsidianOBSIDIAN_VERSIONandOBSIDIAN_EDITIONare honored by your commandlet