#1628: Support for OS specific CVEs - #2370
Open
laert-ll wants to merge 2 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 33053632967Coverage increased (+0.04%) to 73.766%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions47 previously-covered lines in 3 files lost coverage.
Coverage Stats💛 - Coveralls |
laert-ll
force-pushed
the
feature/1628-support-for-os-specific-cves
branch
from
August 27, 2026 08:20
c5309e2 to
e394226
Compare
laert-ll
marked this pull request as ready for review
August 27, 2026 08:22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1628
Implemented changes:
security.jsonCVE model extended so that a single CVE can express affected version ranges that only apply on specific operating systems.conditionsmap to theCvemodel.CveJsonDeserializer/CveJsonSerializerread and writeconditions. It is only written when present, so existingsecurity.jsonfiles remain unchanged.Cve.isAffected(version, os)combines the globalversionswith the current OS's conditional ranges;Cve.merge(...)also merges the per-OS conditions.Testing instructions
Run
mvn clean testManual (single machine):
<IDE_ROOT>/urls/<tool>/<edition>/security.json(create if absent) and add a CVE whose globalversionsdo NOT match the version you'll install, but whoseconditionsfor your current OS (windows/linux/mac) do:{ "issues": [ { "id": "CVE-TEST-OS", "severity": 9.0, "versions": ["(0,0.0.1)"], "conditions": { "linux": ["[<version>]"] } } ] }Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.batand notfeature/921 fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internalpom.xmlfiles or otherwise if runtime dependencies changed, you have updated our LICENSE.asciidoc