BREAKING(http/unstable): remove HEADER and METHOD - #7239
Open
tomas-zijdemans wants to merge 10 commits into
Open
BREAKING(http/unstable): remove HEADER and METHOD#7239tomas-zijdemans wants to merge 10 commits into
HEADER and METHOD#7239tomas-zijdemans wants to merge 10 commits into
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
The unstable Methods module was removed in this PR; the corresponding section in the @std/http module docstring is no longer applicable. Co-authored-by: Cursor <cursoragent@cursor.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7239 +/- ##
==========================================
- Coverage 95.03% 95.01% -0.03%
==========================================
Files 619 616 -3
Lines 51499 51283 -216
Branches 9301 9300 -1
==========================================
- Hits 48940 48724 -216
Misses 2021 2021
Partials 538 538 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
HEADER and METHOD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the unstable
HEADERandMETHODconstants from@std/http. They mirror two IANA registries we'd have to track forever, and they add little over plain strings.Rationale:
HEADER.ETagis"ETag"), and every web API involved (Headers,Request,fetch) takes plain strings. Typo protection is the main benefit, and editor autocomplete covers that.file_server.tswas the only consumer in std, and the plain strings read fine there (see the diff).Both modules have sat unstable for two years with no path to stabilization. Removing them now is cheap. Removing them after stabilization wouldn't be.
If we'd rather keep them, #6991 and #6992 should be merged instead so the constants at least match the current registries.
Earlier discussion: Discord thread