Toolchain: Remove notice of downloading from master branch#7303
Open
Growl1234 wants to merge 1 commit intodeepmodeling:developfrom
Open
Toolchain: Remove notice of downloading from master branch#7303Growl1234 wants to merge 1 commit intodeepmodeling:developfrom
Growl1234 wants to merge 1 commit intodeepmodeling:developfrom
Conversation
Growl1234
changed the title
There was a problem hiding this comment.
Pull request overview
Removes outdated “notice” log lines in stage4 toolchain install scripts (follow-up to #7193’s move away from tracking moving branches), keeping install output aligned with pinned/release-based downloads.
Changes:
- Removed notice
echolines referencing downloads from GitHub master (and a couple of “GitHub Release” notices). - No functional changes to download URLs, checksum verification, or installation steps.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| toolchain/scripts/stage4/install_rapidjson.sh | Removes outdated “downloaded from master” notice before download. |
| toolchain/scripts/stage4/install_nep.sh | Removes outdated “downloaded from master” notice before download. |
| toolchain/scripts/stage4/install_libri.sh | Removes “downloaded in GitHub Release” notice before download. |
| toolchain/scripts/stage4/install_libnpy.sh | Removes “downloaded in GitHub Release” notice before download. |
| toolchain/scripts/stage4/install_libcomm.sh | Removes outdated “downloaded from master” notice before download. |
| toolchain/scripts/stage4/install_cereal.sh | Removes outdated “downloaded from master” notice before download. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #7193.