Skip to content

fix(client): release owned HTTP resources - #108

Open
GregHolmes wants to merge 1 commit into
mainfrom
gh/add-client-lifecycle-minimal
Open

GregHolmes wants to merge 1 commit into
mainfrom
gh/add-client-lifecycle-minimal

Conversation

@GregHolmes

Copy link
Copy Markdown
Collaborator

Summary

  • make DeepgramClient and AsyncDeepgramClient AutoCloseable
  • release dispatcher and connection-pool resources only when the SDK created the OkHttpClient
  • preserve ownership of callers' .httpClient(...) instances
  • document try-with-resources lifecycle management

The separate generated WebSocket teardown/concurrency work is tracked in #107.

Validation

  • ./gradlew spotlessCheck test compileExamples --rerun-tasks
  • Manual production Flux probe: connected a Listen v2 socket, disconnected it, then closed the parent client. The child JVM exited in 772 ms.

Closes #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Provide explicit lifecycle management for shared OkHttp resources

1 participant