feat(plugin): add PluginContext.ControlPlaneURL to the plugin SDK for #225 part 1 - #271
Open
colin-riddell wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of #225.
Plugins all rebuild the same control-plane URL from the injected
DATUM_ORG/DATUM_PROJECT/DATUM_API_HOST. The host injects the API host without a scheme, and if you forget to add one you apparently hit an HTML endpoint and get a "serializer for text/html" error, which isn't much of a clue.So
PluginContext.ControlPlaneURL()now builds it: project scope ifProjectis set, org otherwise. Same precedence asauth update-kubeconfig. It errors if the API host is missing, or if neither scope is set, and says which variable to set.plugin.ControlPlaneURL()is a shorthand, likeplugin.Token(). Paths matchinternal/miloapi/urls.go.The scheme handling is copied from
internal/datumconfigrather than importedinternal/can only be imported inside datumctl.Part 2 the
rest.Confighelper will come in a separate PR as it pulls in client-go.Verification
go test ./plugin/...passes. Table-driven coverage: project-over-org precedence, org-only, a host already carryinghttps://,http://preserved for local dev, trailing slash trimmed, and both error paths. One env-based test covers the package-level function.