Skip to content

Update NoSQLBench version to leverage the latest 5.21.1 - #114

Open
msmygit wants to merge 6 commits into
datastax:mainfrom
msmygit:main
Open

msmygit wants to merge 6 commits into
datastax:mainfrom
msmygit:main

Conversation

@msmygit

@msmygit msmygit commented Jun 6, 2024

Copy link
Copy Markdown
Member
  • Updates minor documentation items.
  • Leverages NoSQLBench to the latest 5.21.x version.
  • Adds dependabot that will help keep the GHA runner versions up to date so as to avoid warnings like as below,
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, test-summary/action@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Comment thread CHANGELOG/CHANGELOG-2.1.md Outdated
@msmygit
msmygit marked this pull request as ready for review June 6, 2024 14:18
@msmygit
msmygit force-pushed the main branch 2 times, most recently from 15efc87 to 957d8a6 Compare June 6, 2024 16:08
@msmygit
msmygit requested a review from lukasz-antoniak as a code owner July 18, 2024 18:02
@msmygit
msmygit force-pushed the main branch 2 times, most recently from 323fdd3 to 370b467 Compare July 18, 2024 19:10
hosts=zdm_tests_origin \
localdc=datacenter1 \
-v
#echo "Running NoSQLBench VERIFY job on ORIGIN"

@grighetto grighetto Jul 18, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without the VERIFY step, this test is pretty much useless because this is what actually compares the stored data against the pseudo-random generated data.
I don't have the context why the NB update is happening in this PR (if it's for some new feature or compatibility with newer C* versions), but if we could still run the old NB with the verify step in addition to this until it's support in the latest NB version, I think it would be ideal.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. NB 5.21 doesnt support verify feature yet.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants