Add API key to cloud build#1940
Merged
vish-cs merged 1 commit intodatacommonsorg:masterfrom Apr 1, 2026
Merged
Conversation
SandeepTuniki
approved these changes
Apr 1, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the cloudbuild.yaml configuration to expose the DC_API_KEY secret to the unit-test step via the Secret Manager. It is recommended to also include this secret in the integration-test step to ensure those tests have the necessary API access.
| waitFor: ['push'] | ||
|
|
||
| secretEnv: | ||
| - DC_API_KEY |
Contributor
There was a problem hiding this comment.
The DC_API_KEY is added to the unit-test step, but it appears to be missing from the integration-test step (lines 39-48). Integration tests typically require API access to verify functionality against real services. Consider adding the secretEnv to the integration-test step as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.