Tb estimated incidence rate WHO import#1938
Open
smarthg-gi wants to merge 4 commits intodatacommonsorg:masterfrom
Open
Tb estimated incidence rate WHO import#1938smarthg-gi wants to merge 4 commits intodatacommonsorg:masterfrom
smarthg-gi wants to merge 4 commits intodatacommonsorg:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces data import scripts and configuration files for WHO adolescent birth rate and tuberculosis estimated incidence rate datasets. The review identified several issues: the adolescent birth rate mapping uses an incorrect denominator, the tuberculosis mapping is missing a required DCID prefix, the error handling in the download script is too narrow, and there are minor cleanup items like a typo in a filename and a commented-out line of code.
statvar_imports/who/adolescent_birth_rate/adolescent_birth_rate_pvmap.csv
Show resolved
Hide resolved
...ts/who/tuberculosis_estimated_incidence_rate/tuberculosis_estimated_incidence_rate_pvmap.csv
Show resolved
Hide resolved
statvar_imports/who/tuberculosis_estimated_incidence_rate/tb_data_download.py
Show resolved
Hide resolved
statvar_imports/who/tuberculosis_estimated_incidence_rate/tb_data_download.py
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Estimated number of new episodes of TB cases arising in a given year per 100 000 population.