Skip to content

Add WHO Number of people diagnosed with a new episode of pulmonary TB whose disease was bacteriologically confirmed#1934

Open
abhishekjaisw wants to merge 4 commits intodatacommonsorg:masterfrom
abhishekjaisw:add-who-tb-data
Open

Add WHO Number of people diagnosed with a new episode of pulmonary TB whose disease was bacteriologically confirmed#1934
abhishekjaisw wants to merge 4 commits intodatacommonsorg:masterfrom
abhishekjaisw:add-who-tb-data

Conversation

@abhishekjaisw
Copy link
Copy Markdown
Contributor

description: "Number of people diagnosed with a new episode of pulmonary TB whose disease was bacteriologically confirmed."

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new data import pipeline for World Health Organization (WHO) tuberculosis statistics, specifically focusing on bacteriologically confirmed pulmonary TB cases. This new data will enrich our health-related datasets. Concurrently, existing test data for the US Census ACS S1251 subject table has been updated and standardized, ensuring consistency and accuracy in demographic data processing.

Highlights

  • New WHO Tuberculosis Data Import: Added a new dataset from the World Health Organization (WHO) for the number of people diagnosed with bacteriologically confirmed pulmonary tuberculosis. This includes a Python script to download the data, along with necessary configuration files (manifest, metadata, and property-value mapping) for processing and importing this data.
  • US Census ACS S1251 Test Data Updates: Updated and renamed existing test data files for the US Census ACS 5-year subject table S1251. This involved reordering properties, adding age group specifications to several statistical variable nodes in the MCF, and updating the summary and column mapping JSON files to reflect new data characteristics and a '2024' year key.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new data import for the "WHO Tuberculosis Dataset: Bacteriologically Confirmed Pulmonary TB", including a Python script to download and process the data, and associated configuration files. It also updates existing ACS5YR subject table files (S1251) to reflect a new data year (2024) and adjusts some property ordering and node names. Feedback includes addressing a missing test data file or generation instructions for the new TB import, updating documentation for filename consistency, and adding warning logs for unmatched countries during data merging.

@abhishekjaisw abhishekjaisw force-pushed the add-who-tb-data branch 2 times, most recently from 35c3da1 to 6879158 Compare March 26, 2026 08:00
@abhishekjaisw
Copy link
Copy Markdown
Contributor Author

/gemini review

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes an old ACS dataset and introduces a new import for the WHO Tuberculosis dataset. The new import includes a Python script to download and process the data, along with configuration files for statistical variable mapping and schema definitions. A critical issue was identified in the download_tb_data.py script where the master_response variable was used without being defined, which needs to be fixed to correctly fetch the master data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant