fix(oauth): add explicit timeouts to direct requests calls#1399
Open
haroldfabla2-hue wants to merge 1 commit intodatabricks:mainfrom
Open
fix(oauth): add explicit timeouts to direct requests calls#1399haroldfabla2-hue wants to merge 1 commit intodatabricks:mainfrom
haroldfabla2-hue wants to merge 1 commit intodatabricks:mainfrom
Conversation
- Add timeout=60 to requests.post() in retrieve_token() (line 209) - Add timeout=60 to requests.get() in get_azure_entra_id_workspace_endpoints() (line 548) - Add timeout=60 to requests.post() in PATOAuthTokenExchange.refresh() (line 916) This prevents indefinite hangs when OAuth endpoints are unreachable or slow, matching the SDK's default http_timeout_seconds of 60 seconds. Resolves databricks#1338
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
|
Please ensure that the NEXT_CHANGELOG.md file is updated with any relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add explicit
timeout=60to directrequestscalls indatabricks/sdk/oauth.pyto prevent indefinite hangs during OAuth/token-exchange flows when endpoints are unreachable or slow.Changes
retrieve_token(): addtimeout=60torequests.post(...)get_azure_entra_id_workspace_endpoints(): addtimeout=60torequests.get(...)PATOAuthTokenExchange.refresh(): addtimeout=60torequests.post(...)Why
These calls bypass
_BaseClientrequest timeout handling. Without an explicit timeout they can block indefinitely inside auth/header refresh paths.Closes #1338