Repository navigation
Fs2524 feature specs - #7364
Draft
Daniel114510 wants to merge 9 commits into
Draft
Fs2524 feature specs#7364Daniel114510 wants to merge 9 commits into
Daniel114510 wants to merge 9 commits into
Conversation
Dropped when rebasing onto the bot's Update Go SDK to v0.194.0 PR. Co-authored-by: Isaac <no-reply@databricks.com>
A feature spec has create, get and delete and no update, and every field is immutable, so any change recreates it. It is a UC function, so its grants go through the existing grants sub-resource with securable type "function"; on a recreate the grants node plans an update and re-applies them. The map-like pair lists (rename_outputs, default_values, input_bindings) are compared by key, and exclude_columns and the extra pip requirements are sorted on both sides, so reordering them is not a recreate. features and the lookup keys stay positional: their order sets the output columns and must match the table's primary key. Co-authored-by: Isaac <no-reply@databricks.com>
… FeatureSpec Replaced by the generator after rebasing onto the SDK bump. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Also give the fake's feature spec map its own block and shorten the recreate prompt. Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
Contributor
|
Commit: Regression test reportSelected 14 changed tests (limit=20, 0 not selected) 662 tests: regression=9 unreleased=0 coverage=651 failing=2
11 more failure details omitted, see the full report in the run. |
Collaborator
Integration test reportCommit: 6ada4aa
26 interesting tests: 26 FAIL
|
Every feature spec case that deploys now sets Cloud = true, and the
invariant matrix no longer skips feature_spec.yml.tmpl on cloud.
Creating a feature spec resolves its lookup tables and UDFs in Unity
Catalog, so each case creates them in a per-run main.fspec_<unique>
schema with create_feature_spec_fixtures.py and drops the schema on
exit. Bundle names carry $UNIQUE_NAME so parallel runs do not share
state. The grants case grants to account users, which exists in every
workspace. The bind case binds a spec created outside the bundle and
plans no change.
The fake's delete now returns {} like the real endpoint.
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Tests