Merged
Conversation
Suggested reviewersBased on git history of the changed files, these people are best suited to review:
Confidence: low Eligible reviewersBased on CODEOWNERS, these people or teams could also review: @anton-107, @denik, @shreyas-goenka, @simonfaltum Suggestions based on git history of 1 changed files (1 scored). See CODEOWNERS for path-specific ownership rules. |
Collaborator
|
Commit: 2e37d1a
17 interesting tests: 10 SKIP, 7 KNOWN
Top 26 slowest tests (at least 2 minutes):
|
pietern
reviewed
Mar 26, 2026
| shell: pwsh | ||
| run: | | ||
| dotnet tool install --global AzureSignTool | ||
| dotnet tool install --global AzureSignTool --version 7.0.1 |
Contributor
There was a problem hiding this comment.
Is there a checksum we can verify here? If not, could you add a comment stating how this installation works, where it pulls binaries from, etc. Would be good to know this version cannot be hijacked.
Contributor
Author
There was a problem hiding this comment.
Not natively, I've added a comment describing how dotnet works
pietern
approved these changes
Mar 27, 2026
| shell: pwsh | ||
| run: | | ||
| dotnet tool install --global AzureSignTool | ||
| dotnet tool install --global AzureSignTool --version 7.0.1 |
Collaborator
|
Commit: 457cfdc
41 interesting tests: 17 RECOVERED, 11 KNOWN, 7 FAIL, 4 flaky, 2 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Lock AzureSignTool to 7.0.1