Fix bundle generate job to preserve nested notebook directory structure#4596
Open
varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
Open
Fix bundle generate job to preserve nested notebook directory structure#4596varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
varundeepsaini wants to merge 1 commit intodatabricks:mainfrom
Conversation
varundeepsaini
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
approved these changes
Feb 27, 2026
Collaborator
|
Commit: baac699
17 interesting tests: 10 SKIP, 7 KNOWN
Top 20 slowest tests (at least 2 minutes):
|
varundeepsaini
force-pushed
the
fix/bundle-generate-job
branch
from
dc572e1 to
6a23c44
Compare
Contributor
Author
|
@andrewnester could you run the checks, there were some issues on windows, have fixed those |
andrewnester
approved these changes
Mar 3, 2026
andrewnester
approved these changes
Mar 3, 2026
Contributor
andrewnester
left a comment
andrewnester
left a comment
There was a problem hiding this comment.
Could you please add a NEXT_CHANGELOG entry for this change, following the format there? Thank you!
varundeepsaini
force-pushed
the
fix/bundle-generate-job
branch
from
6a23c44 to
545af5c
Compare
Contributor
Author
|
@andrewnester done. |
Contributor
|
@varundeepsaini, this change could break for users who continuously run the "bundle generates job" command to sync the files back. At the very least, can you expand this PR to clean up the files at the old location? |
varundeepsaini
force-pushed
the
fix/bundle-generate-job
branch
2 times, most recently
from
2e1b40d to
7f9bca0
Compare
Contributor
Author
|
@andrewnester could you run the ci ? |
Contributor
|
@varundeepsaini sorry for the delay, could you please also resolve merge conflicts? |
varundeepsaini
force-pushed
the
fix/bundle-generate-job
branch
from
7f9bca0 to
8a557b2
Compare
Contributor
Author
|
@andrewnester no worries, thanks a lot for the reviews |
varundeepsaini
force-pushed
the
fix/bundle-generate-job
branch
from
8a557b2 to
4876824
Compare
andrewnester
approved these changes
Mar 16, 2026
varundeepsaini
force-pushed
the
fix/bundle-generate-job
branch
from
d7db5b1 to
454eb63
Compare
Contributor
Author
|
@andrewnester I have fixed the windows test failure, |
andrewnester
approved these changes
Mar 27, 2026
Contributor
Author
|
@andrewnester could you run the ci ? |
Contributor
Author
|
@andrewnester i fixed the test failures, could you re run the ci |
auto-merge was automatically disabled
March 27, 2026 14:42
Head branch was pushed to by a user without write access
varundeepsaini
force-pushed
the
fix/bundle-generate-job
branch
from
1f9e016 to
baac699
Compare
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #4503.
Add
MarkTasksForDownloadthat computes a common base path across all notebook tasks before downloading, replacing the per-task loop injob.go. This preserves nested directory structure instead of flattening all notebooks intosrc/.Tests
commonDirPrefixandMarkTasksForDownload.bundle/generate/job_nested_notebooksreproducing the issue.python_job,ipynb_job,git_jobtests.Test are written by Claude Code