Skip to content

fix: report audit error and pending statuses - #452

Open
JohnsonLyu wants to merge 1 commit into
darnitdevorg:mainfrom
JohnsonLyu:fix/audit-reporting-447
Open

JohnsonLyu wants to merge 1 commit into
darnitdevorg:mainfrom
JohnsonLyu:fix/audit-reporting-447

Conversation

@JohnsonLyu

Copy link
Copy Markdown

Closes #447

Summary

  • Include ERROR and PENDING_LLM in audit text and JSON summaries
  • Show ERROR and PENDING_LLM results in default CLI output
  • Prevent duplicate status sections with --show-all
  • Add regression tests for the reporting behavior

Type of Change

  • Bug fix (non-breaking change fixing an issue)
  • New feature (non-breaking change adding functionality)
  • Breaking change (fix or feature causing existing functionality to change)
  • Documentation update
  • Refactoring (no functional changes)

Framework Changes Checklist

If this PR modifies the darnit framework (packages/darnit/):

  • Updated framework spec (docs/architecture/framework-design.md) if behavior changed
  • Ran uv run python scripts/validate_sync.py --verbose and it passes

Control/TOML Changes Checklist

If this PR modifies controls or TOML configuration:

  • Control metadata defined in TOML (not Python code)
  • SARIF fields (description, severity, help_url) included where appropriate
  • Ran validation to confirm TOML schema compliance

Testing

  • Tests pass locally (uv run pytest tests/ -v)
  • Added tests for new functionality (if applicable)
  • Linting passes (uv run ruff check .)

tests/darnit/test_cli.py: 28 passed. Relevant lint checks pass.

AI assistance

  • No AI assistance was used
  • AI assistance was used

Cursor was used to help inspect the issue, implement the reporting changes, and add tests.

Additional Notes

Signed-off-by: Johnson Lyu <cl7084@nyu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Terminal audit summary omits ERROR and PENDING_LLM: components do not sum to the reported total

2 participants