Skip to content

gtk4-prep: restore right-click node popup and alt+scroll channel tab switching - #21775

Merged
TurboGit merged 1 commit into
darktable-org:masterfrom
Arecsu:gtk4/restore-module-event-forwarding
Aug 9, 2026
Merged

gtk4-prep: restore right-click node popup and alt+scroll channel tab switching#21775
TurboGit merged 1 commit into
darktable-org:masterfrom
Arecsu:gtk4/restore-module-event-forwarding

Conversation

@Arecsu

@Arecsu Arecsu commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Fixes #21774 — right-clicking a color equalizer node opened the module menu instead of the value-entry popup. Alt+scroll channel-tab switching was also lost in atrous, colorzones, denoiseprofile and rawdenoise. Both were regressions from the event signal → event-controller conversion (#21659), which dropped the code that forwarded events to the slider and notebook widgets. The popup is now opened directly — a gesture-based slider can't be fed a synthetic press without corrupting its gesture state — and the alt+scroll forwarding to the channel tabs is restored.

Related: #21774 #15920 #20433

@AxelG-DE

AxelG-DE commented Aug 9, 2026

Copy link
Copy Markdown

Dear @Arecsu I injected the code and it basically fixes #21774.

However, please see the video (sorry screenkey on only towards the end, but merely right-klicking). Sometimes still the menus pops up. That is also the case for 2.6.0, so not related with #21774, but by chance you could fix that in one run? IMHO that menu should only appear when the hamburger is clicked...

20260809b_color-eq_no-context-2026-08-09_16.13.36.mp4

@TurboGit TurboGit added this to the 5.8 milestone Aug 9, 2026
@TurboGit TurboGit added the gtk4 label Aug 9, 2026

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@TurboGit
TurboGit merged commit bd7fc8c into darktable-org:master Aug 9, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color Equalizer does not show context menu anymore when right clicking on the nodes

3 participants