gtk4-prep: restore lighttable scrolling over thumbnail overlays + better smooth scrolling - #21741
Closed
Arecsu wants to merge 2 commits into
Closed
gtk4-prep: restore lighttable scrolling over thumbnail overlays + better smooth scrolling#21741Arecsu wants to merge 2 commits into
Arecsu wants to merge 2 commits into
Conversation
Contributor
Author
|
Superseded by #21745 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21735 — scrolling the lighttable stopped as soon as the pointer was over one of the always-visible thumbnail overlay icons (e.g. the star ratings). Scrolling worked everywhere else: over the thumbnails themselves, and with "overlays on hover" mode.
This was a regression from the scroll-event → event-controller conversion (#21659), which broke two things in the lighttable and culling views:
No behavior changes for mouse wheels, and nothing new is turned on by default — this restores how the lighttable scrolled before the conversion.
Related: #21735 #15920 #20433