gtk4-prep: fix darkroom module header hover freeze and multi-instance clicks - #21726
Merged
Merged
Conversation
Replace the file-static _header_buttons_module with a dt_develop_t field so the state lives in the global darktable struct (avoids static variables, per review feedback on darktable-org#21726).
Arecsu
force-pushed
the
gtk4/iop-header-events
branch
from
August 6, 2026 01:52
1c91f9a to
173f418
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two regressions from the event-controller conversion in #21659 are fixed:
Along the way:
gtk_gesture_single_get_current_button()Separately: middle-click duplication was intentionally replaced by right-click in 2021 (be9d783). Right-click is restored; middle-click does nothing.
Some of these are GTK3-specific fixes that should be cleaned up once a full GTK4 move happens. A few visual bugs seem native to GTK3 and have no clean fix — for instance, moving the cursor slowly out of the sidebar (with buttons set to hide on hover-out) sometimes leaves them shown, and moving to the histogram can do the same. GTK3 just isn't reliably able to assess lack of hover in these scenarios, and tracking it properly would take a lot of verbose code that GTK4 should make unnecessary and cleaner.
These are purely visual quirks, nothing functional — annoying to my visual-obsessive side, but I expect the GTK4 move will smooth out a lot of these UI/UX rough edges anyway.
Related: #15920 #20433
Fixes #21723
CC: @piratenpanda @dtrtuser