gtk4-prep: fix right-click popups on filter and range entries - #21718
Conversation
|
can you also look at middle click module duplication? Might have been the gtk4 transition as well |
Woops, how do I reproduce this one sorry? Just middle clicking the module should duplicate it, and now it stopped doing that? |
|
The icon where you get the menu, the double squares was middle clickable in my recollection and it duplicated the module |
Interestingly enough, after search across git history and the code, the middle click seems to be an unintended behavior. A bug. The correct duplication method is by right-clicking it, not middle clicking it. Either way, it is broken in my gtk4-prep. So I'll fix it to right-click. Even the tooltip says right-click. Curious how some of us were used to a way of doing things to find out it was actually a bug 🤣 |
|
could have been a right click as well, anyway, would be nice to have it back :D |
|
not sure if you want me to update my #21720 issue but also noticed the same right click issue when trying to create new instance of a module with mouse right-click (imageop.c). |
TurboGit
left a comment
There was a problem hiding this comment.
Merging this now as fixing an important bug.
Right-click on text filter entries (camera, lens, flash, filename, ISO, …) shows the default cut/copy menu instead of the "select existing values" popup.
Root cause: the event controller conversion (#21659) attached the entry press gesture with the default button and bubble phase, so GtkEntry's built-in context menu won over the custom popup handler.
Fix: attach the gesture with
GDK_BUTTON_SECONDARYandGTK_PHASE_TARGET, so it claims right-clicks before the entry's default handling. Coversmisc.c(camera/lens/flash/…),filename.c(filename/extension), andrange.c(range-select entries).Related: #15920 #20433
Fixes #21720