Skip to content

gtk4-prep: fix right-click popups on filter and range entries - #21718

Merged
TurboGit merged 2 commits into
darktable-org:masterfrom
Arecsu:gtk4/filter-entries-rightclick
Aug 5, 2026
Merged

gtk4-prep: fix right-click popups on filter and range entries#21718
TurboGit merged 2 commits into
darktable-org:masterfrom
Arecsu:gtk4/filter-entries-rightclick

Conversation

@Arecsu

@Arecsu Arecsu commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Right-click on text filter entries (camera, lens, flash, filename, ISO, …) shows the default cut/copy menu instead of the "select existing values" popup.

Root cause: the event controller conversion (#21659) attached the entry press gesture with the default button and bubble phase, so GtkEntry's built-in context menu won over the custom popup handler.

Fix: attach the gesture with GDK_BUTTON_SECONDARY and GTK_PHASE_TARGET, so it claims right-clicks before the entry's default handling. Covers misc.c (camera/lens/flash/…), filename.c (filename/extension), and range.c (range-select entries).

Related: #15920 #20433

Fixes #21720

@piratenpanda

Copy link
Copy Markdown
Contributor

can you also look at middle click module duplication? Might have been the gtk4 transition as well

@TurboGit TurboGit added this to the 5.8 milestone Aug 5, 2026
@TurboGit TurboGit added the gtk4 label Aug 5, 2026
@Arecsu

Arecsu commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

can you also look at middle click module duplication? Might have been the gtk4 transition as well

Woops, how do I reproduce this one sorry? Just middle clicking the module should duplicate it, and now it stopped doing that?

@piratenpanda

piratenpanda commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

The icon where you get the menu, the double squares was middle clickable in my recollection and it duplicated the module

@Arecsu

Arecsu commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

The icon where you get the menu, the double squares was middle clickable in my recollection and it duplicated the module

Interestingly enough, after search across git history and the code, the middle click seems to be an unintended behavior. A bug. The correct duplication method is by right-clicking it, not middle clicking it. Either way, it is broken in my gtk4-prep. So I'll fix it to right-click. Even the tooltip says right-click. Curious how some of us were used to a way of doing things to find out it was actually a bug 🤣

@piratenpanda

Copy link
Copy Markdown
Contributor

could have been a right click as well, anyway, would be nice to have it back :D

@dtrtuser

dtrtuser commented Aug 5, 2026

Copy link
Copy Markdown

not sure if you want me to update my #21720 issue but also noticed the same right click issue when trying to create new instance of a module with mouse right-click (imageop.c).

@TurboGit TurboGit left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this now as fixing an important bug.

@TurboGit
TurboGit merged commit 6889c11 into darktable-org:master Aug 5, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commit 14cacb2 might have broken filter list with right click

4 participants