Fix #8260 Improve check: Pointer calculation result not null#8061
Open
francois-berder wants to merge 2 commits intodanmar:mainfrom
Open
Fix #8260 Improve check: Pointer calculation result not null#8061francois-berder wants to merge 2 commits intodanmar:mainfrom
francois-berder wants to merge 2 commits intodanmar:mainfrom
Conversation
|
pfultz2
reviewed
Dec 27, 2025
Contributor
pfultz2
left a comment
pfultz2
left a comment
There was a problem hiding this comment.
This should be done in valueflow. If there is a plus with a non zero value on a pointer, it should be set to !0. This can probably be done in the valueFlowImpossibleValues pass.
test/testcondition.cpp
Outdated
| ASSERT_EQUALS("[test.cpp:2:15]: (warning) Comparison is wrong. Result of 'ptr+1' can't be 0 unless there is pointer overflow, and pointer overflow is undefined behaviour. [pointerAdditionResultNotNull]\n", errout_str()); | ||
|
|
||
| // #8260 | ||
| check("void f(int *p) {\n" |
Collaborator
There was a problem hiding this comment.
Is it worth adding a test for the original example from #8260?
Signed-off-by: Francois Berder <fberder@outlook.fr>
Contributor
Author
|
@pfultz2 I finally had time to fix my PR. I rebased my PR on top of main branch, implemented your suggestion and added more test cases. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.