[samimaattaCelia]

Relates to #501
I went through the tests I had made before and compared them with the specification and the Finnish curriculum, so that the tests would cover them well enough.

I also made some fixes to some tests' MathML and the braille output.

If more tests are needed, then I need more information on what kind of tests, since to me these seem to cover pretty well what is expected of the 6-dot braille. It is mainly used for comprehensive school levels of mathematics.

[moritz-gross]

some checks initially failed because of a problem with the "zip" package that MathCAT depends on.
I have rerun them as the authors seem to have fixed it, but now there are failures regarding the Finnish tests it seems?

@samimaattaCelia can you click on the failing tests and see if the logs are helpful to you?

[samimaattaCelia]

Do you mean the tests that are not passing? If so, then the rules need to be changed so the tests pass.

[moritz-gross]

Do you mean the tests that are not passing? If so, then the rules need to be changed so the tests pass.

yes, 2 jobs are failing.

---

I copied part of the log where it shows the failing tests:

here

failures:
    braille::Finnish::spec::chemical_formula_parentheses_2
    braille::Finnish::spec::half_open_interval_right
    braille::Finnish::spec::matrix_with_empty_cells
    braille::Finnish::spec::msub_with_vector
    braille::Finnish::spec::msub_with_vector_arrow
    braille::Finnish::spec::msub_with_vector_with_sub_text
    braille::Finnish::spec::msubsup_with_vector
    braille::Finnish::spec::msubsup_with_vector_complex_with_parentheses
    braille::Finnish::spec::nth_order_derivative
    braille::Finnish::spec::open_interval
    braille::Finnish::spec::operate_by_on_both_sides
    braille::Finnish::spec::operate_by_on_both_sides_double_bars
    braille::Finnish::spec::p16_division
    braille::Finnish::spec::p17_multiple_operations
    braille::Finnish::spec::p22_equation_solving_notation
    braille::Finnish::spec::p22_equation_solving_notation_double_bars
    braille::Finnish::spec::p22_fraction_division_Finnish_notation_mmultiscripts
    braille::Finnish::spec::p25_long_fraction
    braille::Finnish::spec::p46_first_order_derivative_alt
    braille::Finnish::spec::p49_integral_with_Finnish_notation_for_substitution
    braille::Finnish::spec::p49_sequence_with_lower_upper_bounds
    braille::Finnish::spec::p49_summation_with_lower_upper_bounds
    braille::Finnish::spec::p50_binomial_with_factorial
    braille::Finnish::spec::second_order_derivative_alt_1
    braille::Finnish::spec::second_order_derivative_alt_2

test result: FAILED. 1476 passed; 25 failed; 31 ignored; 0 measured; 0 filtered out; finished in 16.54s

A pull request can only be merged if the checks pass, so it it needs to be fixed first. can you see why/how the checks fail?

[samimaattaCelia]

In the past, the changes have been merged, so that Neil can modify the rules after the fact. Isn't this still how translators are supposed to work? I don't have the know-how to modify the rules so that the tests pass.

[moritz-gross]

hm ok, makes sense.
The easiest way would be to merge the PR only after the rules are adjusted accordingly.
Usually, the status on main is expected to be the finished clean product with all tests passing.
I recently learned that that one can also push to branches on forked repos, so Neil can work directly here I think.

@NSoiffer does this make sense? @samimaattaCelia thanks for your work!

[samimaattaCelia]

I should add that this is a fork of branch fi-braille, so I'm not pushing to main directly.

[moritz-gross]

hm yes, not sure how to handle this then.
I'll just let Neil handle it haha

[samimaattaCelia]

Yes, we talked about this in the MathCAT working group yesterday, so he is aware. Thanks!