feat(shared): open achievement picker from tracker button#5529
Merged
rebelchris merged 4 commits intomainfrom Feb 20, 2026
Merged
feat(shared): open achievement picker from tracker button#5529rebelchris merged 4 commits intomainfrom
rebelchris merged 4 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
@claude fix linting and make sure all circleCI are green. (*it's only one file changed) |
Contributor
|
Claude finished @rebelchris's task in 2m 13s —— View job Lint fixes applied
Root cause: The old Changes made in commit
|
…TrackerButton Removes leftover body of old useCallback handler and cleans up now-unused imports (useLogContext, LogEvent, TargetType) that were part of the old navigation-based handleClick implementation. Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AchievementPickerModalopening.AchievementTrackerButton(achievements,trackedAchievement,trackAchievement) to power modal selection and tracking.Key Decisions
AchievementTrackingWidgetto minimize risk and keep behavior consistent.useCallbackwrappers in this component.packages/shared/src/components/filters/AchievementTrackerButton.tsxonly.Issue: ENG-751 - Achievement tracker feedback
Linear: https://linear.app/dailydev/issue/ENG-751/achievement-tracker-feedback
Closes ENG-751
Created by Huginn 🐦⬛
Preview domain
https://eng-751-achievement-tracker-feed.preview.app.daily.dev