Skip to content

feat(shared): open achievement picker from tracker button#5529

Merged
rebelchris merged 4 commits intomainfrom
eng-751-achievement-tracker-feedback
Feb 20, 2026
Merged

feat(shared): open achievement picker from tracker button#5529
rebelchris merged 4 commits intomainfrom
eng-751-achievement-tracker-feedback

Conversation

@rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Feb 19, 2026

Summary

  • Replace feed header achievement tracker button navigation with inline AchievementPickerModal opening.
  • Reuse existing data/hooks in AchievementTrackerButton (achievements, trackedAchievement, trackAchievement) to power modal selection and tracking.
  • Keep existing feature flag, loading behavior, and button size/variant logic unchanged.

Key Decisions

  • Followed the established modal pattern from AchievementTrackingWidget to minimize risk and keep behavior consistent.
  • Simplified handler implementation by removing unnecessary useCallback wrappers in this component.
  • Limited scope to packages/shared/src/components/filters/AchievementTrackerButton.tsx only.

Issue: ENG-751 - Achievement tracker feedback
Linear: https://linear.app/dailydev/issue/ENG-751/achievement-tracker-feedback

Closes ENG-751


Created by Huginn 🐦‍⬛

Preview domain

https://eng-751-achievement-tracker-feed.preview.app.daily.dev

@rebelchris rebelchris requested a review from a team as a code owner February 19, 2026 18:48
@vercel
Copy link

vercel bot commented Feb 19, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
daily-webapp Ready Ready Preview Feb 20, 2026 7:28am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
storybook Ignored Ignored Feb 20, 2026 7:28am

Request Review

@rebelchris
Copy link
Contributor Author

@claude fix linting and make sure all circleCI are green. (*it's only one file changed)

@claude
Copy link
Contributor

claude bot commented Feb 20, 2026

Claude finished @rebelchris's task in 2m 13s —— View job


Lint fixes applied

  • Read the changed file and check CI status
  • Fix orphaned code and unused imports
  • Commit and push changes

Root cause: The old handleClick was a useCallback with navigation logic. When replacing it with the new modal-opening version, the body of the old callback was accidentally left behind as orphaned code (lines 100-109 in the original), causing syntax errors and unused import warnings.

Changes made in commit bdbdce8:

  • Removed orphaned code block (leftover useCallback body with logEvent, push, and webappUrl references)
  • Removed unused imports: useLogContext, LogEvent, TargetType
  • Removed unused logEvent destructure

…TrackerButton

Removes leftover body of old useCallback handler and cleans up now-unused
imports (useLogContext, LogEvent, TargetType) that were part of the old
navigation-based handleClick implementation.

Co-authored-by: Chris Bongers <rebelchris@users.noreply.github.com>
@rebelchris rebelchris merged commit 5cb11a2 into main Feb 20, 2026
11 checks passed
@rebelchris rebelchris deleted the eng-751-achievement-tracker-feedback branch February 20, 2026 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant