bugfix: HTML Formatter and its envelopes#1891
Conversation
|
@oellul this is a quick attempt at fixing it. One thing to note, is this might not play well with attachments, especially those from hooks. So for now I want to let this sit for a short while |
|
No worries, take your time. My monkey-patch seems to be serving my use case well for now (probably because I don't use attachments) |
|
@oellul can you test this branch though with attachments. To see if you can remove your monkeypatch. I want to merge this in as it is an oversight on our end |
|
Sure thing, I'll test it out tomorrow and let you know |
|
@luke-hill You're right, it doesn't play well with attachments. This step def When('I attach an image') do
image_path = File.read('image.jpeg', mode: 'rb')
attach(image_path, 'image/jpeg')
endis failing with error message This particular issue is fixed when changing |
* Fix up arabic translation example Fix step defs to use native terms Fix capture to ensure scenario will work * Permit arabic to run again in CI * Switch ukranian to use anglicised step def code to permit example to be ran in CI - Still validly testing the parser and the localised terms in gherkin * Switch uzbek to use anglicised step def code to permit example to be ran in CI - Still validly testing the parser and the localised terms in gherkin * Switch russian to use anglicised step def code to permit example to be ran in CI - Still validly testing the parser and the localised terms in gherkin * Enhance test suite to run all new examples * Add note * Add changelog
* Remove the ancient procedure call interface from formatters completely * Until now the data from "attach" and "log" calls from step definitions has been passed to the formatter using the ancient procedure call interface used in Cucumber-Ruby v1 and v2. From Cucumber-Ruby v3 all other data to formatters has been passed using events. * Introduce an event AttachCalled to pass the data from "attach" and "log" calls from step definitions to event listeners like formatters. * Update Changelog.md
luke-hill
force-pushed
the
bugfix/html_formatter_inheritance
branch
from
e34037c to
4134b83
Compare
luke-hill
force-pushed
the
bugfix/html_formatter_inheritance
branch
from
52f9a52 to
55d09e7
Compare
|
Not quite sure what went on with merges / interactive rebases but @oellul could you take a look here again. Both with positive and negative scenarios for the html formatter |
4 participants
Description
Fix HTML formatter not running output_envelope correctly
fixes #1890
Type of change
Please delete options that are not relevant.
Please add an entry to the relevant section of CHANGELOG.md as part of this pull request.
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses