Extract query to cucumber query#1889
Draft
mattwynne wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extract
Cucumber::QueryandCucumber::Repositoryout of cucumber-ruby and consume them from the new cucumber-query Ruby gem.The query implementation has been moved to the cucumber-query PR branch, and this PR wires cucumber-ruby to that branch until cucumber-query is merged and released.
Motivation: the query/repository code is message-querying infrastructure and belongs in cucumber-query rather than inside cucumber-ruby. Keeping cucumber-ruby green while depending on cucumber-query gives us a safe migration path before replacing the temporary git dependency with a released gem dependency.
Depends on cucumber/query PR: TODO
Type of change
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses