Skip to content

Extract query to cucumber query#1889

Draft
mattwynne wants to merge 3 commits into
mainfrom
extract-query-to-cucumber-query
Draft

Extract query to cucumber query#1889
mattwynne wants to merge 3 commits into
mainfrom
extract-query-to-cucumber-query

Conversation

@mattwynne

Copy link
Copy Markdown
Member

Description

Extract Cucumber::Query and Cucumber::Repository out of cucumber-ruby and consume them from the new cucumber-query Ruby gem.

The query implementation has been moved to the cucumber-query PR branch, and this PR wires cucumber-ruby to that branch until cucumber-query is merged and released.

Motivation: the query/repository code is message-querying infrastructure and belongs in cucumber-query rather than inside cucumber-ruby. Keeping cucumber-ruby green while depending on cucumber-query gives us a safe migration path before replacing the temporary git dependency with a released gem dependency.

Depends on cucumber/query PR: TODO

Type of change

  • Refactoring (improvements to code design or tooling that don't change behaviour)

Checklist:

Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.

  • New and existing tests are passing locally and on CI
  • bundle exec rubocop reports no offenses
  • RDoc comments have been updated
  • CHANGELOG.md has been updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant