Skip to content

fix: add type guards when rendering env progression dates #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityachoudhari26 merged 1 commit into from
Apr 22, 2026
+40 −16
Merged

fix: add type guards when rendering env progression dates #1030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 40 additions & 16 deletions ...nts/_components/environmentversiondecisions/rule-results/EnvironmentProgressionDetail.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,15 @@ type ProgressionDetails = {
failed_environments?: number;
};

function safeFormatDistanceToNowStrict(
value: Date | string | null | undefined,
) {
if (value == null) return null;
const date = value instanceof Date ? value : new Date(value);
if (isNaN(date.getTime())) return null;
return formatDistanceToNowStrict(date);
}

function extractEnvDetails(details: Record<string, unknown>): PerEnvDetail[] {
const envDetails: PerEnvDetail[] = [];
for (const [key, value] of Object.entries(details)) {
Expand Down Expand Up @@ -127,6 +136,35 @@ function SoakTimeStatus({ detail }: { detail: PerEnvDetail }) {
);
}

function LastSuccessLine({
mostRecentSuccess,
}: {
mostRecentSuccess?: string;
}) {
const formatted = safeFormatDistanceToNowStrict(mostRecentSuccess);
if (formatted == null) return null;
return (
<div className="flex items-center gap-1.5 text-xs text-muted-foreground">
<Clock className="size-3" />
<span>Last success: {formatted} ago</span>
</div>
);
}

function NextEvaluationLine({
nextEvaluationAt,
}: {
nextEvaluationAt: Date | null;
}) {
const formatted = safeFormatDistanceToNowStrict(nextEvaluationAt);
if (formatted == null) return null;
return (
<span className="shrink-0 text-muted-foreground">
re-check in {formatted}
</span>
);
}

function EnvironmentCard({ detail }: { detail: PerEnvDetail }) {
const minRequired = detail.minimum_success_percentage ?? 100;
const passRatePassed =
Expand Down Expand Up @@ -167,16 +205,7 @@ function EnvironmentCard({ detail }: { detail: PerEnvDetail }) {
</div>
)}

{detail.most_recent_success && (
<div className="flex items-center gap-1.5 text-xs text-muted-foreground">
<Clock className="size-3" />
<span>
Last success:{" "}
{formatDistanceToNowStrict(new Date(detail.most_recent_success))}{" "}
ago
</span>
</div>
)}
<LastSuccessLine mostRecentSuccess={detail.most_recent_success} />
</div>
);
}
Expand Down Expand Up @@ -292,12 +321,7 @@ function ProgressionRow({
allPassed={allPassed}
isPending={isPending}
/>
{!allPassed && rule.nextEvaluationAt != null && (
<span className="shrink-0 text-muted-foreground">
re-check in{" "}
{formatDistanceToNowStrict(new Date(rule.nextEvaluationAt))}
</span>
)}
{!allPassed && <NextEvaluationLine {...rule} />}
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<NextEvaluationLine {...rule} /> spreads the entire RuleEvaluation object into a component that only needs nextEvaluationAt. This increases coupling (the component becomes implicitly dependent on RuleEvaluation’s shape) and can mask future prop name collisions. Pass nextEvaluationAt={rule.nextEvaluationAt} explicitly (and consider typing the prop as RuleEvaluation["nextEvaluationAt"] to keep it in sync).

Suggested change
{!allPassed && <NextEvaluationLine {...rule} />}
{!allPassed && (
<NextEvaluationLine nextEvaluationAt={rule.nextEvaluationAt} />
)}

Copilot uses AI. Check for mistakes.
</DialogTrigger>
<DialogContent>
<DialogHeader>
Expand Down
Loading