Feat/pgo v3 by henderkes · Pull Request #1138 · crazywhalecc/static-php-cli

henderkes · 2026-05-11T07:34:25Z

What does this PR do?

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

If you modified *.php or *.json, run them locally to ensure your changes are valid:
- composer cs-fix
- composer analyse
- composer test
- bin/spc dev:sort-config
If it's an extension or dependency update, please ensure the following:
- Add your test combination to src/globals/test-extensions.php.
- If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

…ywhere

github-actions · 2026-05-12T00:52:59Z

StaticPHP Test Bot

Detected: Extensions: fastchart, fastjson | Libraries: bzip2, fastlz, icu, imagemagick, jbig, krb5, libaom, libffi, libheif, liblz4, libpng, ncurses, openssl, postgresql, qdbm, unixodbc, watcher | Targets: llvm-compiler-rt, llvm-tools, php
Active labels: none
Config: Linux x86_64 + Windows x86_64 + macOS arm64 | PHP 8.5 NTS

henderkes · 2026-05-12T01:24:38Z

(I tested with static-php/packages v3 branch, php 8.5 zig on rpm. Tests with Alpine and gcc are still to finish in a few hours when ci runs.)

henderkes · 2026-05-12T01:26:00Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

crazywhalecc · 2026-05-12T01:50:27Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

…ith different pkg_root_path set

…fined behaviour sanitizer)

henderkes · 2026-05-12T04:27:00Z

Wair, why is curl a target like php and not a package/library? We don't compile the exe right?

We could compile curl.exe, which shows that StaticPHP is not only suitable for building static PHP, but also for other projects. Just like we already support building pkg-config and re2c. Making them targets simply makes reasonable.

target is superset of library.

Okay, added curl.exe on Windows too. Also figured out the root cause of the BUILD_CC patch minilua crash (zigs undefined behaviour sanitizer tripping up, if you run CC="clang -fsanitize=undefined" it will also fail) which coincidentally also fixed a possible edge case bug. BUILD_CC is also used for gen_ir so by using a different vm type it could have theoretically clashed.

henderkes · 2026-05-12T05:59:38Z

Oh, there's even an issue running the binaries despite no undefined sanitizer that I can't reproduce locally or in docker. Very weird.

crazywhalecc · 2026-07-15T06:02:36Z

    }

-    public function config(array $packages = [], bool $include_suggests = false): array
+    public function config(array $packages = []): array


Directly and permanently relying on PackageInstaller's resolved packages prevents SPCConfigUtil from being used in standalone commands or other vendor-mode scenarios. I suggest splitting this into two methods: keep config() as is, and add function configForResolvedPackages(array $roots, array $resolvedPackages, array $phpExtras = []) {} to distinguish the use cases.

spc-config retains its original semantics.

The build process respects the actual resolution results from PackageInstaller.

It avoids linking suggests that haven't been built.

It does not rely on implicit DI state.

Unit tests only require passing arrays, eliminating the need to construct a full installer instance.

Identical inputs consistently yield identical outputs.

I will apply fix for SPCConfigUtil in a separate new branch. This is not strictly part of PGO.

This seems a bit tricky; I think it would be better to split the various changes into separate PRs for review and merging. I have already completed some unrelated changes in #1214, and I am about to create a PR for the SPCConfigUtil refactoring (including the relevant files). Once all the changes unrelated to PGO have been merged, I will review the pgo-v3 changes and submit them to a new, clean branch.

crazywhalecc · 2026-07-27T06:08:13Z

-      name: opentelemetry
+      type: pie
+      repo: open-telemetry/ext-opentelemetry
+      build-root: ext


How about subdir? build-root is definitely ambiguous. Also, move all the previous metadata.source-root here.

build-dir?

subdir doesn't say what that directory is used for

Keep using source-root? build-dir sounds ambiguous too (out-of-source building). The name source-root also corresponds to our API getSourceRoot(). Although it still doesn't accurately describe our needs, it essentially redirects the source root.

Two diffrremt things, we need both of them.

Another approach is to completely redirect everything using source-root, eliminating the need to worry about subdirectories during in-tree extension builds:

All artifacts are uniformly extracted to source/{name}

During static compilation of PHP extensions, a symbolic link is created to the root directory or the specified source-root to php-src/ext/{name}

Shared extensions remain unaffected

After doing this, our previous source-root and the current source-root for PHP extensions are actually the same thing.

Are you sure that doesn't have edge cases with extension configs resolving to absolute paths before? If it's working with all extensions I think that's a good idea.

The test still set the removed metadata.source-root key, so it asserted a subdir that getSourceRoot() never applied. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011pkXY3NUGDanB7c1RGj8eA

Backport lcms2 support for ImageMagick from #1243. Omit matrix-filter tests that depend on newer v3 command behavior.

henderkes added 5 commits May 10, 2026 19:27

toolchain fixes forward port from v2-pgo

4f76942

better deduplicate_flags

6e32672

update libraries to honour user flags

efdd2a7

use resolved dependency tree instead of asking for with_suggests ever…

743934d

…ywhere

add pgo capabilities v3 style

7e6e9d8

henderkes force-pushed the feat/pgo-v3 branch from 4f57a12 to 7e6e9d8 Compare May 11, 2026 13:55

henderkes added 2 commits May 11, 2026 21:05

Merge remote-tracking branch 'origin/v3' into feat/pgo-v3

bfaa7eb

reset registry

a585359

henderkes marked this pull request as ready for review May 11, 2026 14:49

henderkes requested a review from crazywhalecc May 11, 2026 14:49

crazywhalecc added the need-test This PR has not been tested yet, cannot merge now label May 12, 2026

henderkes added 7 commits May 12, 2026 09:54

use {pkg_root_path} for packages, otherwise containers get confused w…

4172508

…ith different pkg_root_path set

cant reset it because of the same reason x(

270e2d6

trust filesystem, not downloads

c1c34d8

fix BUILD_CC=cc workaround root cause (minijit trips zig default unde…

8453f69

…fined behaviour sanitizer)

fix phpunit failure

57ef042

wrong exception type

defd50f

array

814014e

henderkes force-pushed the feat/pgo-v3 branch from b5d6e3c to 814014e Compare May 12, 2026 04:20

henderkes added 2 commits May 12, 2026 11:22

we don't need this anymore

2415b7d

also build curl exe on windows

4754faf

henderkes added 3 commits May 12, 2026 11:30

don't add fno-sanitize=undefined for library builds

445c0b3

oops

9addbe2

allow * stage to subscribe to everything

b880ef7

henderkes added 2 commits July 9, 2026 19:27

fix gmssl and event properly..

6b6a099

dont pass invalid empty gh token

a65441b

crazywhalecc requested changes Jul 15, 2026

View reviewed changes

henderkes added 12 commits July 21, 2026 00:34

blub

6060a6c

fix smth

404b2dc

fix swoole trying to load under fpm/frankenphp

1778032

update extensions from pecl to pie

9bceaac

simpler fix for swoole

15e2b7b

default extract for pie sources

b437b2f

default extract for pie source number 2

0299ed5

extract shared-only extensions into their own folder

81213f5

pecl for those

6ba9cd2

imagick on pecl too, version substitute...

ed0863d

move opentelemetry back to PIE

347a3c3

igbinary PIE

3b425b6

crazywhalecc reviewed Jul 27, 2026

View reviewed changes

henderkes and others added 13 commits July 31, 2026 11:26

extra ldflags Libphp.so

3bd142a

Update ext-event.yml

02df4a2

php 8.6 compatibility with all bundled extensions

a5a8d0e

more fixes for 8.6

de3ee11

more fixes for 8.6

600d08e

update php-rar

657960d

php 8.6.0~beta1 compatibility

341d82d

php 8.6.0~beta1 compatibility 2

497ebae

apply #1240

2824de2

work around gnu mirrors constantly being down

7d3e1f8

apply #1243

5a1ddb5

Backport lcms2 support for ImageMagick from #1243. Omit matrix-filter tests that depend on newer v3 command behavior.

bundle zip in php-src if available there

a6ffbc0

henderkes marked this pull request as draft September 22, 2026 16:19

Uh oh!

Conversation

henderkes commented May 11, 2026

What does this PR do?

Checklist before merging

Uh oh!

github-actions Bot commented May 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

henderkes commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

crazywhalecc commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

henderkes commented May 12, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented May 12, 2026 •

edited

Loading