Skip to content

Fix libde265 on arm64 macOS asm build bug#1117

Open
crazywhalecc wants to merge 2 commits intomainfrom
fix/libde265
Open

Fix libde265 on arm64 macOS asm build bug#1117
crazywhalecc wants to merge 2 commits intomainfrom
fix/libde265

Conversation

@crazywhalecc
Copy link
Copy Markdown
Owner

What does this PR do?

Closes #1116

Checklist before merging

If your PR involves the changes mentioned below and completed the action, please tick the corresponding option.
If a modification is not involved, please skip it directly.

  • If you modified *.php or *.json, run them locally to ensure your changes are valid:
    • composer cs-fix
    • composer analyse
    • composer test
    • bin/spc dev:sort-config
  • If it's an extension or dependency update, please ensure the following:
    • Add your test combination to src/globals/test-extensions.php.
    • If adding new or fixing bugs, add commit message containing extension test or test extensions to trigger full test suite.

'-DENABLE_SDL=OFF',
'-DENABLE_DECODER=OFF'
'-DENABLE_DECODER=OFF',
'-DHAVE_ARM=OFF',
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps do this on mac only? neon are generally helpful in my builds on rhel 9 & 10

Copy link
Copy Markdown
Owner Author

@crazywhalecc crazywhalecc Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux aarch64 may also have this bug though.

However, considering this chain: libde265-libheif-imagemagick-imagick, the only function of libde265 assembly should be HEVC/HEIF things. I'm not sure if adding this assembly is worthwhile for the benefit of this extension. In any case, arm64 assembly is likely missing, it only has armv7 assembly. x86 assembly is compatible with x64, which may explain why it has consistently compiled successfully.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, libde265 have HAVE_NEON option, this looks more accurate, and we don't worry about x86, it just because it depends on HAVE_ARM which is negative on x86. Let me change to HAVE_NEON=OFF.

Suggested change
'-DHAVE_ARM=OFF',
'-DHAVE_NEON=OFF',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mpociot does this still fix your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to build libde265 on ARM64 macOS

2 participants