Fix libde265 on arm64 macOS asm build bug#1117
Conversation
| '-DENABLE_SDL=OFF', | ||
| '-DENABLE_DECODER=OFF' | ||
| '-DENABLE_DECODER=OFF', | ||
| '-DHAVE_ARM=OFF', |
There was a problem hiding this comment.
perhaps do this on mac only? neon are generally helpful in my builds on rhel 9 & 10
There was a problem hiding this comment.
Linux aarch64 may also have this bug though.
However, considering this chain: libde265-libheif-imagemagick-imagick, the only function of libde265 assembly should be HEVC/HEIF things. I'm not sure if adding this assembly is worthwhile for the benefit of this extension. In any case, arm64 assembly is likely missing, it only has armv7 assembly. x86 assembly is compatible with x64, which may explain why it has consistently compiled successfully.
There was a problem hiding this comment.
Oh wait, libde265 have HAVE_NEON option, this looks more accurate, and we don't worry about x86, it just because it depends on HAVE_ARM which is negative on x86. Let me change to HAVE_NEON=OFF.
| '-DHAVE_ARM=OFF', | |
| '-DHAVE_NEON=OFF', |
What does this PR do?
Closes #1116
Checklist before merging
*.phpor*.json, run them locally to ensure your changes are valid:composer cs-fixcomposer analysecomposer testbin/spc dev:sort-configsrc/globals/test-extensions.php.extension testortest extensionsto trigger full test suite.