[WIP] Fix php 8.3 avx512 check despite cached vars#1114
Closed
Conversation
The issue was that SPC_EXTRA_PHP_VARS (containing php_cv_have_avx512=no and php_cv_have_avx512vbmi=no) were being passed as command-line arguments to ./configure instead of as environment variables. This caused PHP's autoconf system to ignore the cached values and run AVX512 checks anyway. Changes: - LinuxBuilder.php: Parse SPC_EXTRA_PHP_VARS and add them to the environment variable array that's passed to configure - Extension.php: Apply the same fix for shared extension builds The variables are now properly set in the environment before configure runs, allowing PHP's autoconf cache system to recognize and use them. Agent-Logs-Url: https://github.com/crazywhalecc/static-php-cli/sessions/03f84520-e96c-4748-aa05-bfd98e26fed8 Co-authored-by: crazywhalecc <20330940+crazywhalecc@users.noreply.github.com>
Collaborator
|
No, useless approach. I'll do it later. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.