optimized std::stack usage in simplecpp::TokenList::combineOperators()#659
Open
firewave wants to merge 2 commits into
Open
optimized std::stack usage in simplecpp::TokenList::combineOperators()#659firewave wants to merge 2 commits into
std::stack usage in simplecpp::TokenList::combineOperators()#659firewave wants to merge 2 commits into
Conversation
…cpp::TokenList::combineOperators()`
…`simplecpp::TokenList::combineOperators()`
Collaborator
Author
|
This cuts the Ir for the function in question in half. Running GCC 16 - |
danmar
reviewed
Jun 20, 2026
| { | ||
| std::stack<bool> executableScope; | ||
| executableScope.push(false); | ||
| std::stack<bool, std::vector<bool>> executableScope{{false}}; |
Collaborator
There was a problem hiding this comment.
isn't std::vector<bool> bad to use overall in c++11..
are you sure that all usage here will work fine..
Collaborator
Author
There was a problem hiding this comment.
As this is about performance and valgrind indicates that is fine in either compiler so I see no problem.
libc++ has been adding special handling for vector<bool> and we are also not using it as a bit field here (which is the common usage for that IIRC).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::vectoras underlying container forstd::stackstd::stackwith initial value instead of inserting it