fixed #504 / refs #507 - cleaned up and improved parsing of #line preprocessor directive#586
Open
firewave wants to merge 1 commit into
Open
fixed #504 / refs #507 - cleaned up and improved parsing of #line preprocessor directive#586firewave wants to merge 1 commit into
#line preprocessor directive#586firewave wants to merge 1 commit into
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
firewave
force-pushed
the
line-comment
branch
4 times, most recently
from
5fa16f3 to
4c9bcb4
Compare
firewave
changed the title
#line preprocessor directive
firewave
changed the title
#line preprocessor directive#line preprocessor directive
…d up and improved parsing of line preprocessor directive
danmar
reviewed
Jun 20, 2026
| if (!ppTok || !ppTok->number) | ||
| continue; | ||
|
|
||
| const unsigned int line = std::atol(ppTok->str().c_str()); |
Collaborator
There was a problem hiding this comment.
could you please add a (portability) warning and some handling for wrong values? I believe negative values for instance are undefined behavior. The C99 specification says that it must be "digit-sequence". And:
the digit sequence shall not specify zero, nor a number greater than 2147483647.
Collaborator
Author
There was a problem hiding this comment.
I guess you mean a warn if the GNU extension version is being used. I think if the non-supporting compilers (i.e. MSVC) reject it that is unnecessary.
Regarding the handling of more (any) invalid values I would like to handle that through a separate issue and PR as a follow-up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.