Fix #15081 (usability: try to report misuse of exclude options) by danmar · Pull Request #8906 · cppcheck-opensource/cppcheck

danmar · 2026-09-30T19:57:00Z

No description provided.

Copilot

Copilot review overview

🟡 Changes recommended

Overlapping patterns are misreported, some build paths no longer compile, and GUI project analysis omits validation.

Review effort: Balanced
Findings: 1 · 2 · 2

Open (5)

Update callers for the non-const PathMatch API · New
Propagate unused excludes in GUI project analysis · New
Evaluate all patterns when recording overlapping matches · New
Separate unused-path advice into a clear sentence · New
Fix run-on warning text around suppression advice · New

What changed in this PR

Adds detection and reporting for unused ignore/exclude patterns across CLI and GUI analysis flows.

Changes:

Tracks matched patterns in PathMatch.
Reports unused exclusions during CLI and GUI analysis.
Adds coverage for matching and reporting behavior.

File	Description
`lib/pathmatch.h`	Adds match tracking API and state.
`lib/pathmatch.cpp`	Records matched patterns.
`lib/importproject.h`	Returns unmatched project exclusions.
`lib/importproject.cpp`	Collects unmatched project exclusions.
`cli/filelister.h`	Makes matcher parameters mutable.
`cli/filelister.cpp`	Propagates mutable matchers.
`cli/cmdlineparser.cpp`	Rejects unused exclusions.
`gui/filelist.h`	Exposes unmatched exclusions.
`gui/filelist.cpp`	Computes unmatched exclusions.
`gui/mainwindow.cpp`	Displays unused-exclusion warnings.
`gui/test/filelist/testfilelist.h`	Declares new GUI tests.
`gui/test/filelist/testfilelist.cpp`	Tests unmatched GUI exclusions.
`test/testpathmatch.cpp`	Tests pattern tracking.
`test/testfilelister.cpp`	Updates matcher usage.
`test/testcmdlineparser.cpp`	Tests CLI validation.
`test/helpers.cpp`	Updates helper matcher usage.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot

Copilot review overview

🔵 Needs a closer look

Windows compilation is broken, and several paths can incorrectly or inconsistently report unused exclusions.

Review effort: Balanced
Findings: 1 · 2 · 2

Open (5)

Update callers for the non-const PathMatch API
Evaluate all patterns when recording overlapping matches
Propagate unused excludes in GUI project analysis
Fix run-on warning text around suppression advice
Separate unused-path advice into a clear sentence

Previously missed (1)

In code that hasn't changed since last review

Validate project excludes against the complete file set

gui/mainwindow.cpp:694

This check evaluates project-wide excludes only against the current files argument. checkProject() passes recheckFiles here when rechecking a modified subset (mainwindow.cpp:1986-1995), so any valid project exclude that only matches a file outside that subset is reported as unused and the recheck is aborted. Restrict this validation to a full analysis, or validate against the complete project input set rather than the recheck subset.

Copilot

Copilot review overview

🟡 Changes recommended

Overlapping patterns and partial GUI analyses can incorrectly report valid exclusions as unused.

Review effort: Balanced
Findings: 2

Open (2)

Avoid redundant exclusion pass when no exclusion list exists · New
Avoid validating project exclusions against partial recheck files · New

Resolved since last review (5)

Update callers for the non-const PathMatch API
Evaluate all patterns when recording overlapping matches
Propagate unused excludes in GUI project analysis
Fix run-on warning text around suppression advice
Separate unused-path advice into a clear sentence

Copilot

Copilot review overview

🟡 Changes recommended

Pattern coverage can incorrectly hide genuinely unused exclusions.

Review effort: Balanced
Findings: 1

Open (1)

Restrict coverage exemptions to patterns matching directories · New

Resolved since last review (2)

Avoid validating project exclusions against partial recheck files
Avoid redundant exclusion pass when no exclusion list exists

+        // paths inside a matched directory are not traversed, so a pattern that is
+        // covered by a matched pattern is considered used
+        const Filemode mode = !s.empty() && PathIterator::issep(s.back(), mSyntax) ? Filemode::directory : Filemode::regular;
+        return std::none_of(mMatchedPatterns.cbegin(), mMatchedPatterns.cend(), [&](const std::string& matched) {
+            return match(matched, s, mBasepath, mode, mSyntax);


Copilot AI balanced review requested due to automatic review settings September 30, 2026 19:57

Copilot started reviewing on behalf of danmar September 30, 2026 19:59 View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

Comment thread cli/filelister.h

Comment thread lib/importproject.cpp

Comment thread lib/pathmatch.cpp Outdated

Comment thread cli/cmdlineparser.cpp

Comment thread gui/mainwindow.cpp

Copilot AI balanced review requested due to automatic review settings September 30, 2026 20:01

Copilot started reviewing on behalf of danmar September 30, 2026 20:03 View session

Copilot AI reviewed Sep 30, 2026

View reviewed changes

danmar force-pushed the unused-exclude branch from 120ee29 to e0bb151 Compare October 1, 2026 14:48

danmar marked this pull request as ready for review October 1, 2026 16:30

danmar requested a balanced review from Copilot October 1, 2026 16:30

danmar force-pushed the unused-exclude branch from e0bb151 to f790e2a Compare October 1, 2026 16:35

Copilot started reviewing on behalf of danmar October 1, 2026 16:35 View session

Copilot AI reviewed Oct 1, 2026

View reviewed changes

Comment thread gui/filelist.cpp

Comment thread gui/mainwindow.cpp Outdated

Fix #15081 (usability: try to report misuse of exclude options)

4a9bd45

danmar force-pushed the unused-exclude branch from daf0148 to 4a9bd45 Compare October 1, 2026 17:40

danmar changed the title ~~Unused exclude~~ Fix #15081 (usability: try to report misuse of exclude options) Oct 1, 2026

danmar requested a balanced review from Copilot October 2, 2026 04:29

Copilot started reviewing on behalf of danmar October 2, 2026 04:30 View session

Copilot AI reviewed Oct 2, 2026

View reviewed changes

Navigation Menu

Fix #15081 (usability: try to report misuse of exclude options) - #8906

Fix #15081 (usability: try to report misuse of exclude options)#8906
danmar wants to merge 1 commit into
cppcheck-opensource:mainfrom
cppchecksolutions:unused-exclude

danmar commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

danmar commented Sep 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants