Fix ticket 8442: detect unselectable switch cases - #8815
Open
JeewoongKim wants to merge 3 commits into
Open
Conversation
JeewoongKim
changed the title
JeewoongKim
force-pushed
the
fix-8442-unreachable-switch-case
branch
from
August 29, 2026 12:46
52f4e2e to
f4ca315
Compare
| { | ||
| reportError(tok, Severity::style, "unreachableSwitchCase", | ||
| "Switch case '" + caseExpression + | ||
| "' can never be selected because the switch condition has a known value.", |
Collaborator
There was a problem hiding this comment.
Thanks for your contribution. It might be helpful to mention the known value in the error message.
Author
There was a problem hiding this comment.
Updated the message to include the known value. thanks.
Collaborator
|
Please add a short note in releasenotes.txt. |
Author
Added a short note. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueFlow already knows the switch condition value in this case,
but the case labels were not checked against it.
This change uses that value to report case labels that cannot be
selected when the switch condition has a known integer value.
Added regression tests for enum and integer cases, unknown
switch values, and nested switches.