Skip to content

refactor!: make buffer_param an implementation detail - #408

Merged
sgerbino merged 2 commits into
cppalliance:developfrom
sgerbino:pr/buffer-refactor
Oct 30, 2026
Merged

sgerbino merged 2 commits into
cppalliance:developfrom
sgerbino:pr/buffer-refactor

Conversation

@sgerbino

Copy link
Copy Markdown
Collaborator

Follows cppalliance/capy#479.

  • buffer_param moves to namespace detail. It appears only in the virtual interfaces that stream and backend implementations override, so it leaves the user guide and glossary. The name is unchanged.
  • Adopts capy's renamed buffer_sequence_begin / buffer_sequence_end.
  • Removes the docs for capy's removed buffer_slice and now-private consuming_buffers.

Merge order: after cppalliance/capy#479. Until then this PR's CI resolves capy develop, which lacks the new names.

buffer_param appears only in the virtual interfaces that stream and
backend implementations override, so it moves to namespace detail and
leaves the user guide and glossary. Adopt capy's renamed
buffer_sequence_begin and buffer_sequence_end, and remove the docs for
capy's removed buffer_slice and now-private consuming_buffers.
@github-actions

github-actions Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Benchmark report

41d0de18b6e4 (base) vs 244bfaee44ea (head)

  • ❌ linux — no results (job failed or runner offline)
  • ❌ windows — no results (job failed or runner offline)
  • ❌ macos — no results (job failed or runner offline)

Run & raw JSON artifacts · flag rule: |median Δ| > max(2%, 3×CV of the noisier side) · advisory only

@cppalliance-bot

cppalliance-bot commented Oct 30, 2026 •

Copy link
Copy Markdown

An automated preview of the documentation is available at https://408.corosio.prtest3.cppalliance.org/index.html

If more commits are pushed to the pull request, the docs will rebuild at the same URL.

2026-10-30 22:15:40 UTC

OpenSSL 4.1 no longer matches hostnames against the subject CN, so
every SNI and hostname test failed verification against the CN-only
test certificate. Reissue it from the same key with the same subject,
which keeps the CA path hash, and rebuild the PKCS#12 bundle from it.
@sgerbino
sgerbino merged commit b135a6f into cppalliance:develop Oct 30, 2026
45 of 48 checks passed
@github-project-automation github-project-automation Bot moved this from Backlog to Done in Beast2 Oct 30, 2026
@sgerbino
sgerbino deleted the pr/buffer-refactor branch October 30, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants