Skip to content

fix: never release the process-lifetime Winsock hold #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgerbino merged 1 commit into from
Oct 28, 2026
Merged

fix: never release the process-lifetime Winsock hold #407

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions include/boost/corosio/native/detail/iocp/win_wsa_init.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,29 +53,17 @@ win_wsa_init_count() noexcept
return count;
}

// Hold Winsock for the life of the process, so the count never falls back
// to zero between one io_context and the next. An asynchronous
// GetAddrInfoExW keeps settling inside ws2_32 past its completion
// routine, with no way to observe when, and a WSACleanup under it faults
// on a system DNS thread.
// Hold Winsock for the life of the process and never release it, so the
// count never falls to zero. An asynchronous GetAddrInfoExW keeps
// settling inside ws2_32 past its completion routine, with no way to
// observe when, and a WSACleanup under it faults on a system DNS thread.
// That includes one run from a static destructor at exit; process
// teardown reclaims Winsock without it.
inline void
win_wsa_hold_process() noexcept
{
struct holder
{
holder() noexcept
{
::InterlockedIncrement(&win_wsa_init_count());
}

~holder()
{
if (::InterlockedDecrement(&win_wsa_init_count()) == 0)
::WSACleanup();
}
};

static holder const instance;
[[maybe_unused]] static bool const held =
(::InterlockedIncrement(&win_wsa_init_count()), true);
}

inline win_wsa_init::win_wsa_init()
Expand Down
Loading