Skip to content

[feat][trace] parallelize span and annotation queries in GetTrace#582

Merged
cuichen01 merged 3 commits into
mainfrom
ft_cc_annotation_query_update
Jul 15, 2026
Merged

[feat][trace] parallelize span and annotation queries in GetTrace#582
cuichen01 merged 3 commits into
mainfrom
ft_cc_annotation_query_update

Conversation

@cuichen01

Copy link
Copy Markdown
Collaborator

…n spanIDs provided

When SpanIDs are passed in the request, we already know which span IDs to query annotations for, so both queries can run concurrently via errgroup instead of sequentially waiting for spans to complete first.

What type of PR is this?

Check the PR title

  • This PR title match the format: [<type>][<scope>] <description>. For example: [fix][backend] flaky fix
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Add documentation if the current PR requires user awareness at the usage level.
  • This PR is written in English. PRs not in English will not be reviewed.

(Optional) Translate the PR title into Chinese

(Optional) More detailed description for this PR(en: English/zh: Chinese)

en:
zh(optional):

(Optional) Which issue(s) this PR fixes

…n spanIDs provided

When SpanIDs are passed in the request, we already know which span IDs
to query annotations for, so both queries can run concurrently via
errgroup instead of sequentially waiting for spans to complete first.
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
backend/modules/observability/infra/repo/trace.go 96.77% 1 Missing and 1 partial ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
+ Coverage   78.18%   78.19%   +0.01%     
==========================================
  Files         670      670              
  Lines       76566    76608      +42     
==========================================
+ Hits        59862    59904      +42     
  Misses      13266    13266              
  Partials     3438     3438              
Flag Coverage Δ
unittests 78.19% <96.82%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...bservability/domain/trace/service/trace_service.go 88.59% <100.00%> (ø)
backend/modules/observability/infra/repo/trace.go 86.25% <96.77%> (+1.11%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7d6cbb...6963f52. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuichen01
cuichen01 merged commit f77ecd2 into main Jul 15, 2026
16 checks passed
@cuichen01
cuichen01 deleted the ft_cc_annotation_query_update branch July 15, 2026 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants