E2e migration update

[kaze-cow]

Description

Forking off the original e2e-migration branch, finish the E2E tests migration. This PR has been pending for a while and needed some updates based on the latest state of solidity/plans for the future of the protocol, so its been updated/adapted.

Concretely, this branch differs from the original branch by:

• updating OpenZeppelin to 5.5.0 (the latest), which supports solidity 0.8, simplifying some aspects of the tests such as delpoyment of openzepplin test contracts
• remove tests related to balancer/internal balances functionality. This will not be used in the next version of the protocol.
• updating the code to work with the latest foundry warnings cleaned
• ran forge fmt
• update hardhat (this wasnt directly related to any issues with the codebase, but it was causing yarn to fail install on my ARM hardware and updating seems to have no noticable negative effect at this time)

The actual diff between original e2e testing brnach can be seen here (individual commits viewing is helpful due to the forge fmt): e2e-migration...e2e-migration-update

The previous branch was pretty scant on documentation and review, and never received a review in the first place. The original reviewers are no longer here, and some lint fixes from upstream foundry are needed, so may we just start again with this branch?

Test Plan

The new tests can be verified with FORK_URL=<url of mainnet> forge test. There are no more tests in hardhat. We may consider removing hardhat entirely?

Related Issues

#226

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	ts-node@​10.9.1 ⏵ 10.9.2	+1
	hardhat@​2.13.1 ⏵ 2.28.0			+4	-1
	@​openzeppelin/​contracts@​3.4.0-solc-0.7 ⏵ 5.5.0		+75	+6	+3

View full report

[socket-security]

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action	Severity	Alert  (click "▶" to expand/collapse)
Warn		Obfuscated code: npm safer-buffer is 94.0% likely obfuscated Confidence: 0.94 Location: Package overview From: ? → npm/hardhat@2.28.0 → npm/safer-buffer@2.1.2 ℹ Read more on: This package | This alert | What is obfuscated code? Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev. Suggestion: Packages should not obfuscate their code. Consider not using packages with obfuscated code. Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/safer-buffer@2.1.2. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

[anxolin]

It doesn't build for me. For example, I can't find this file:

[anxolin]

Also, @kaze-cow please remember to set the correct base branch to see the actual changes. You are based in e2e-migration. It's good to always check the changes in your own PRs. In this case, it would have shown 7K changes.

[anxolin]

Should we cleanup and get these merged?

forge build fails for me

 --> src/contracts/GPv2Settlement.sol:7:1:
  |
7 | import {IGPv2Settlement} from "./interfaces/IGPv2Settlement.sol";
  | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Can we make sure tests are passing?

[anxolin]

Changes the public getter function name, this affects the ABI, is this intended?
and also should it be in e2e migration PRs or should it be an independent one?