Convert heavy queries from 5xx to 4xx#7374
Draft
eeldaly wants to merge 2 commits intocortexproject:masterfrom
Draft
Convert heavy queries from 5xx to 4xx#7374eeldaly wants to merge 2 commits intocortexproject:masterfrom
eeldaly wants to merge 2 commits intocortexproject:masterfrom
Conversation
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
Signed-off-by: Essam Eldaly <eeldaly@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR introduces a timeout in querier (default 59s) to timeout before we hit the ambassador timeout. Once this is hit, we convert queries that took longer than X (default 40s) PromQL evaluation time from 5XX to 4XX. This conversion and 1s earlier timeout is disabled by default.
Default new configs:
querier.timeout-classification-enabled: falsequerier.timeout-classification-deadline: 59squerier.timeout-classification-eval-threshold: 40sResponse Outputs:
Current output on timeout:
New output on timeout (non-breaching):
New output on timeout (breaching):
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]