simplify() fixes from PR/301#307
Merged
Merged
Conversation
…fyNonCommutativeFunction (This inadvertently resulted in *full*-rule simplification of all operands for all functions Correcting this has resulted in *no broken tests*)
Member
|
Looks good. Thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Is constituted by the fixes in the domain of simplification, as requested in #301. Constituted by sole commit
Forgoes inclusion of 'Refactor (workaround): during simplification, do not simplify all numeric operands of 'lazy' operator definitions' (from PR/301); in favour of this being raised as an issue in #306.