feat(checkpoints): coordinate managed headless workspace writers - #7
Open
brandonrjacobs wants to merge 1 commit into
Open
brandonrjacobs wants to merge 1 commit into
brandonrjacobs wants to merge 1 commit into
Conversation
Signed-off-by: Brandon Jacobs <bjacobs@coreweave.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkpoint suspend currently requires an application-supplied writer gate. Add opt-in
--managed-headlesssessions so CLI commands and uploads coordinate withdown --checkpoint-dirthrough a built-in gate.The source sandbox durably closes admission before draining active commands. Linux child subreapers wait for detached descendants; a lost supervisor leaves an unconfirmed receipt and prevents checkpointing. Abort tombstones fence delayed quiesce requests. The existing READY receipt, durable manifest, and stop recovery sequence remains responsible for committing the checkpoint. Restore preserves managed mode and initializes admission in the fresh sandbox.
run/exec, streaming uploads, and config imports. Preserve streaming I/O and the workload's file-creation permissions.Validation:
git diff --checkpassed. Offline commands are documented in CONTRIBUTING.md; Linux gate tests usepython -m unittest discover -s tests -p test_managed_gate.py -v.