Repository navigation
attempt recovery of wedged mutations - #240
Draft
ianmacartney wants to merge 15 commits into
Draft
ianmacartney wants to merge 15 commits into
ianmacartney wants to merge 15 commits into
Conversation
This was referenced Sep 18, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
commit: |
Resolve batch-worker merge leftovers in loop.ts: - vCompletion.runResult now uses vResultInternal so stuckInScheduler flows through the batch to handleCompletions. - Remove the duplicate backoffMs block left by the merge (it redeclared the variable and dereferenced possibly-undefined work.retryBehavior).
ianmacartney
commented
Sep 18, 2026
Comment on lines
+493
to
+496
| // Mutations only retry when recovery replaces a stuck scheduler run. | ||
| if (work.fnType === "mutation") { | ||
| state.report.conflicted = (state.report.conflicted ?? 0) + 1; | ||
| recordCompleted(console, work, "retrying conflicted", undefined); |
Member
Author
There was a problem hiding this comment.
i don't think this is a very important distinction, and "conflicted" is the wrong verb. "rescheduled" is better
ianmacartney
force-pushed
the
ian/use-commit-ts
branch
from
October 9, 2026 06:24
98666b0 to
65c31bd
Compare
ianmacartney
force-pushed
the
ian/recover-mutations-commit-ts
branch
from
October 9, 2026 06:24
7492484 to
14a510a
Compare
ianmacartney
changed the base branch from
ian/use-commit-ts
to
graphite-base/240
October 10, 2026 01:35
ianmacartney
force-pushed
the
graphite-base/240
branch
from
October 22, 2026 01:39
65c31bd to
98666b0
Compare
ianmacartney
changed the base branch from
graphite-base/240
to
ian/use-commit-ts
October 22, 2026 01:39
ianmacartney
changed the base branch from
ian/use-commit-ts
to
graphite-base/240
October 28, 2026 02:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
attempt recovery of wedged mutations
fix merge artifacts breaking the build
Resolve batch-worker merge leftovers in loop.ts:
flows through the batch to handleCompletions.
the variable and dereferenced possibly-undefined work.retryBehavior).
Simplify stuck mutation recovery with commit-ordered retries