Update various dependencies#138
Merged
Merged
Conversation
Many are over a year old. Sure, that can be (and is being) handled in downstream consumers, but running the library's tests against the more relevant implementations is valuable in itself. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
github.com/stretchr/testify still imports the old one, but that is test-only and will not cause that YAML version to be included in binaries of consumers of this library. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
…ng/protobuf Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Luap99
pushed a commit
to containers/container-libs
that referenced
this pull request
May 26, 2026
Almost a year ago, we were waiting for a hopefully-imminent /v4 to migrate. That's still not happened, so move now. The remaining users are ocicrypt, which will be fixed by containers/ocicrypt#138 , and testify, which is test-only. Fixes #187 . Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Collaborator
Same here. But from what I can see with my testing with imgcrypt it looks good. I will merge this soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gopkg.in/yaml.v3. The replacement is a direct continuation, should be non-invasiveNote the Go bump to 1.25 — but the CI is no longer testing 1.24 either.
Warning: I know very little about Protobuf / GRPC. AFAICT the change of the implementation should not affect the wire format, but my testing was limited to “do tests still pass”.