Skip to content

Add check on gl_PointCoords before applying circular mask for point rendering#230

Open
DamienGilliard wants to merge 9 commits intocompas-dev:mainfrom
DamienGilliard:main
Open

Add check on gl_PointCoords before applying circular mask for point rendering#230
DamienGilliard wants to merge 9 commits intocompas-dev:mainfrom
DamienGilliard:main

Conversation

@DamienGilliard
Copy link
Copy Markdown

@DamienGilliard DamienGilliard commented Apr 6, 2026

Hi,
This is a pull request following issue #229 , to fix a visibitily issue of points when on linux. I appears that gl_PointCoord is not always valid, thus when relying on it to apply a circular mask to display round dots for points, the whole point disappears. This fix first checks that the gl_PointCoord is valid before applying the mask, and if it is not valid, the mask is not applied

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I added new functions/classes and made them available on a second-level import, e.g. compas.datastructures.Mesh.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

@DamienGilliard DamienGilliard marked this pull request as draft April 6, 2026 11:17
@DamienGilliard
Copy link
Copy Markdown
Author

DamienGilliard commented Apr 6, 2026

I have tested my changes on several platforms to see if it was working correctly. Seems alright
I was a bit surprised that on ubuntu with nvidia gpu the points were round but on fedora with igpu they were square... opengl is delightful :p

  • Works on macos:
    Screenshot 2026-04-06 at 13 55 44

  • Works on Windows with nvidia gpu
    image

  • Works on Windows with intel igpu
    image

  • works on Linux with nvidia gpu
    image

  • works on Linux with intel igpu (square points because mask bypassed)
    image

@DamienGilliard DamienGilliard marked this pull request as ready for review April 8, 2026 15:03
@DamienGilliard
Copy link
Copy Markdown
Author

Hi @Licini or whoever it may concern, This PR is ready for discussion and review if you think it is worth merging. I encountered this issue ( #229 ) on Fedora with an intel igpu. I have tested this fix on as many platforms as I could, and it seems to work fine.
Cheers !!

@petrasvestartas
Copy link
Copy Markdown
Collaborator

Thank you for PR! Li will have PhD defense very very soon;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants