Add check on gl_PointCoords before applying circular mask for point rendering#230
Open
DamienGilliard wants to merge 9 commits intocompas-dev:mainfrom
Open
Add check on gl_PointCoords before applying circular mask for point rendering#230DamienGilliard wants to merge 9 commits intocompas-dev:mainfrom
DamienGilliard wants to merge 9 commits intocompas-dev:mainfrom
Conversation
… platforms but linux
…n that flags the OS
…r mask on point rendering
Add check on gl_PointCoords to avoid applying circular mask on points if the gl_PointCoords are invalid due to platform/driver shenanigans
update change log and remove inadvertantly added line
Author
|
I have tested my changes on several platforms to see if it was working correctly. Seems alright |
Author
Collaborator
|
Thank you for PR! Li will have PhD defense very very soon;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.





Hi,
This is a pull request following issue #229 , to fix a visibitily issue of points when on linux. I appears that gl_PointCoord is not always valid, thus when relying on it to apply a circular mask to display round dots for points, the whole point disappears. This fix first checks that the gl_PointCoord is valid before applying the mask, and if it is not valid, the mask is not applied
What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.