Repository navigation
fix: support cancellation of conditional passkey autofill - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional passkey autofill can remain pending after a single-page application removes its login form. Add an optional third
AbortSignalargument toautocomplete(redirectLocation, additionalParams, signal)so consumers can cancel on unmount or before another sign-in method starts.The signal reaches both HTTP requests and the WebAuthn ceremony. Cancellation checks between stages prevent subsequent submission or redirect even when an asynchronous operation finishes after cancellation. Existing calls without a signal preserve their defaults, additional parameters, payload, and redirect behavior. Applications own the controller; cancellation cannot undo authentication already processed by the server.
Update the usage documentation and regenerate the shipped browser bundle.
Validation: all 10 JavaScript tests pass, including legacy invocation compatibility, cancellation at each asynchronous stage, and propagation through the shipped bundle to
navigator.credentials.get. The CommandBox dependency packaging task andgit diff --checkpass. TestBox, hosted CI, and actual password-manager extension behavior were not verified for this JavaScript-only change.Formatter workflow repair: pin CFFormat to 0.21.0 and run
format:checkwithout committing changes. CFFormat 0.22.1 repeatedly added whitespace before struct-key colons, and formatter commits triggered further workflow runs. Remove the accumulated formatting churn. Local validation confirms two clean checks, no changes on a second formatting pass, and exit status 1 for an unformatted glob fixture.