-
Notifications
You must be signed in to change notification settings - Fork 141
refactor(registry/coder-labs/modules/codex)!: remove agentapi, tasks and start logic #879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
35C4n0r
wants to merge
17
commits into
main
Choose a base branch
from
35C4n0r/codex-exorcism
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
a1a37e4
refactor(registry/coder-labs/modules/codex): replace agentapi with co…
7e3493b
fix(registry/coder-labs/modules/codex): remove sandbox_mode, approval…
d33796e
docs(registry/coder-labs/modules/codex): describe base_config_toml de…
b478e88
fix(registry/coder-labs/modules/codex): remove notice.model_migration…
e98831d
docs(registry/coder-labs/modules/codex): clarify model_provider and m…
63c2d97
refactor(registry/coder-labs/modules/codex): remove dead codex_model …
0539729
refactor(registry/coder-labs/modules/codex): remove install_codex, no…
06378c2
debug
35C4n0r bb9633d
debug
35C4n0r 91f80c2
fix(registry/coder-labs/modules/codex): restore install_codex variabl…
f33a282
fix(registry/coder-labs/modules/codex): move NVM source inside instal…
e835cce
fix(registry/coder-labs/modules/codex): add npm-global prefix fallbac…
013dc7b
docs(registry/coder-labs/modules/codex): remove Prerequisites and wor…
e53db19
docs(registry/coder-labs/modules/codex): note that custom base_config…
a1c8bbf
remove unwanted link
35C4n0r 3584424
fix(registry/coder-labs/modules/codex): address review comments
c869b97
fix(registry/coder-labs/modules/codex): move npm check after NVM sour…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P3 [DEREM-16] The upgrade warning mentions Tasks and Boundary removal but does not mention that
install_node()/ NVM bootstrap was also removed. A user upgrading from v4 whose base image relied on the module's Node.js bootstrapping getsnpm: command not foundwith no link to the v5 changes.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Upgrade warning now reads: "v5 also assumes npm is pre-installed; it no longer bootstraps Node.js."