-
Notifications
You must be signed in to change notification settings - Fork 141
feat(claude-code): add api_key_helper for short-lived credentials; mark anthropic_api_key sensitive #865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
morganl-ant
wants to merge
1
commit into
coder:main
Choose a base branch
from
morganl-ant:anthropic/api-key-helper
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(claude-code): add api_key_helper for short-lived credentials; mark anthropic_api_key sensitive #865
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ ARG_CLAUDE_BINARY_PATH="$${ARG_CLAUDE_BINARY_PATH//\$HOME/$HOME}" | |
| ARG_MCP=$(echo -n '${ARG_MCP}' | base64 -d) | ||
| ARG_MCP_CONFIG_REMOTE_PATH=$(echo -n '${ARG_MCP_CONFIG_REMOTE_PATH}' | base64 -d) | ||
| ARG_ENABLE_AI_GATEWAY='${ARG_ENABLE_AI_GATEWAY}' | ||
| ARG_API_KEY_HELPER_SCRIPT=$(echo -n '${ARG_API_KEY_HELPER_SCRIPT}' | base64 -d) | ||
|
|
||
| export PATH="$${ARG_CLAUDE_BINARY_PATH}:$PATH" | ||
|
|
||
|
|
@@ -29,6 +30,7 @@ printf "ARG_CLAUDE_BINARY_PATH: %s\n" "$${ARG_CLAUDE_BINARY_PATH}" | |
| printf "ARG_MCP: %s\n" "$${ARG_MCP}" | ||
| printf "ARG_MCP_CONFIG_REMOTE_PATH: %s\n" "$${ARG_MCP_CONFIG_REMOTE_PATH}" | ||
| printf "ARG_ENABLE_AI_GATEWAY: %s\n" "$${ARG_ENABLE_AI_GATEWAY}" | ||
| printf "ARG_API_KEY_HELPER_SCRIPT: %s\n" "$${ARG_API_KEY_HELPER_SCRIPT:+(set)}" | ||
|
|
||
| echo "--------------------------------" | ||
|
|
||
|
|
@@ -144,11 +146,40 @@ function setup_claude_configurations() { | |
|
|
||
| } | ||
|
|
||
| function setup_api_key_helper() { | ||
| if [ -z "$${ARG_API_KEY_HELPER_SCRIPT}" ]; then | ||
| return | ||
| fi | ||
|
|
||
| echo "Configuring api_key_helper for short-lived credentials..." | ||
|
|
||
| mkdir -p "$HOME/.claude" | ||
| local helper_path="$HOME/.claude/coder-api-key-helper.sh" | ||
| printf '%s' "$${ARG_API_KEY_HELPER_SCRIPT}" > "$${helper_path}" | ||
| chmod 0700 "$${helper_path}" | ||
|
|
||
| local dropin_dir="/etc/claude-code/managed-settings.d" | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wonder how this ties into #863 |
||
| local target="$${dropin_dir}/20-coder-apikeyhelper.json" | ||
| if command_exists sudo; then | ||
| sudo mkdir -p "$${dropin_dir}" | ||
| printf '{"apiKeyHelper":"%s"}\n' "$${helper_path}" | sudo tee "$${target}" > /dev/null | ||
| sudo chmod 0644 "$${target}" | ||
| elif mkdir -p "$${dropin_dir}" 2> /dev/null; then | ||
| printf '{"apiKeyHelper":"%s"}\n' "$${helper_path}" > "$${target}" | ||
| chmod 0644 "$${target}" | ||
| else | ||
| echo "Warning: cannot write to $${dropin_dir} (no sudo and not writable); api_key_helper will not be registered" | ||
| return | ||
| fi | ||
|
|
||
| echo "Wrote api_key_helper script to $${helper_path} and registered via $${target}" | ||
| } | ||
|
|
||
| function configure_standalone_mode() { | ||
| echo "Configuring Claude Code for standalone mode..." | ||
|
|
||
| if [ -z "$${ANTHROPIC_API_KEY:-}" ] && [ -z "$${CLAUDE_CODE_OAUTH_TOKEN:-}" ] && [ "$${ARG_ENABLE_AI_GATEWAY}" = "false" ]; then | ||
| echo "Note: No authentication configured (anthropic_api_key, claude_code_oauth_token, enable_ai_gateway), skipping onboarding bypass" | ||
| if [ -z "$${ANTHROPIC_API_KEY:-}" ] && [ -z "$${CLAUDE_CODE_OAUTH_TOKEN:-}" ] && [ "$${ARG_ENABLE_AI_GATEWAY}" = "false" ] && [ -z "$${ARG_API_KEY_HELPER_SCRIPT}" ]; then | ||
| echo "Note: No authentication configured (anthropic_api_key, claude_code_oauth_token, enable_ai_gateway, api_key_helper), skipping onboarding bypass" | ||
| return | ||
| fi | ||
|
|
||
|
|
@@ -189,4 +220,5 @@ EOF | |
|
|
||
| install_claude_code_cli | ||
| setup_claude_configurations | ||
| setup_api_key_helper | ||
| configure_standalone_mode | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need as explicit if we can do the same via #863