🤖 feat: ship generated install bundle and CI freshness checks#89
🤖 feat: ship generated install bundle and CI freshness checks#89
Conversation
- add a kustomize-based installer composition under config/default - generate dist/install.yaml from a real Makefile file target with a phony alias - auto-regenerate CRD/RBAC kustomization.yaml files in hack/update-manifests.sh - update getting-started docs to use the bundled installer manifest - add CI verification that installer outputs are up to date --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.82`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.82 -->
|
@codex review Please review the installer bundle generation and CI freshness check changes. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d749540f83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codex review identified that the freshness check only diffed the installer bundle and kustomization files, which could miss stale generated CRD/RBAC source manifests. This update now diffs `config/crd/bases/` and `config/rbac/` directories directly. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.82`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.82 -->
|
@codex review Addressed your feedback by diffing full generated CRD and RBAC directories in the freshness check. |
|
Codex Review: Didn't find any major issues. 🎉 ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
- split installer generation into two outputs: - dist/minimal-installer.yaml - dist/quickstart-installer.yaml - keep dist/install.yaml as a compatibility alias to the minimal installer - move default installer composition to a coder-system-only minimal stack - add quickstart kustomize resources to seed a namespace, template, and workspace - update CI freshness checks to validate both generated installer outputs - refresh getting-started docs to use the minimal installer and optional quickstart seeding --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.82`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.82 -->
|
@codex review Follow-up change: split generated installer output into minimal and quickstart manifests, |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 988d23cd03
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Extend installer freshness validation to fail when generated artifacts are present but untracked, not just when tracked files differ. --- _Generated with `mux` • Model: `openai:gpt-5.3-codex` • Thinking: `xhigh` • Cost: `$0.82`_ <!-- mux-attribution: model=openai:gpt-5.3-codex thinking=xhigh costs=0.82 -->
|
@codex review Addressed the review comment by making the installer freshness job fail on untracked generated files too. |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
This PR adds a generated, single-file installer manifest (
dist/install.yaml) so users can install the operator stack with onekubectl apply -finstead of manually applying multiple CRD/RBAC/deployment manifests.Background
Installation docs currently require applying many manifests one by one. That is error-prone and cumbersome compared with common operator distribution patterns that publish a single install bundle.
Implementation
config/default/:config/default/kustomization.yamlconfig/default/namespace-coder-system.yamlconfig/default/namespace-coder.yamlconfig/crd/bases/kustomization.yamlconfig/rbac/kustomization.yamlhack/update-manifests.shto auto-regenerate the CRD/RBACkustomization.yamlfiles after controller-gen runs.Makefiletargets:dist/install.yamlbuild-installergo tool kustomize build ...go.modtool block and updated vendored dependencies.docs/tutorials/getting-started.md) to install/cleanup with the bundled installer manifest..github/workflows/ci.yamlto verify generated installer artifacts are up-to-date and wired it intopublish-maingating.Validation
make manifestsmake build-installermake docs-checkmake buildmake testmake lintmake verify-vendorgo tool actionlintRisks
dist/install.yamlplus generated kustomization files.Generated with
mux• Model:openai:gpt-5.3-codex• Thinking:xhigh• Cost:$0.82