fix: pass remote OS to Toolbox agent deployment - #351
Merged
Conversation
Toolbox reads deployment settings from the SSH environment contents view, not from the parent remote environment. The API documentation did not make that ownership clear, so identifying the issue required tracing the Toolbox bytecode through its connection and agent deployment flow. Toolbox's default OS detection also masked the bug during testing: connections could still work even though our override was being ignored. Expose the setting on EnvironmentView, cover every OS mapping, and log the selected OS from BeforeConnectionHook before deployment starts.
jeremyruppel
approved these changes
Aug 24, 2026
Collaborator
Author
|
Thank you @jeremyruppel. I'm gonna hold the merging for a while now, in the hopes that JB folks can take a brief look over this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Toolbox reads deployment settings from the SSH environment contents view, not from the parent remote environment. The API documentation did not make that ownership clear, so identifying the issue required tracing the Toolbox bytecode through its connection and agent deployment flow.
Toolbox's default OS detection also masked the bug during testing: connections could still work even though our override was being ignored. Expose the setting on EnvironmentView, cover every OS mapping, and log the selected OS from BeforeConnectionHook before deployment starts.